Update the new app template to use CMake instead of Android.mk #34354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38460536 |
Base commit: 84fc580 |
Base commit: 84fc580 |
…ook#34354) Summary: Pull Request resolved: facebook#34354 This change simplifies the setup for New Architecture for users on Android. Instead of using the Android.mk file, users can now use a CMake file which encapsulate a lot of the complexities and reduces the maintainance cost. Android.mk support is kept for backward compatibility. Changelog: [Android] [Changed] - Update the new app template to use CMake instead of Android.mk Reviewed By: cipolleschi Differential Revision: D38460536 fbshipit-source-id: 244dbd3936c3ff238905bcb2b2c9e91a008af8bc
|
This pull request was exported from Phabricator. Differential Revision: D38460536 |
cortinico
force-pushed
the
export-D38460536
branch
from
5e4190f
to
6075c53
Compare
|
(do we want this in 0.70?) |
I discussed a bit about it with @cipolleschi. That's up for debate. Users could use this functionality in 0.70 if they wish. I just haven't updated the template to don't add too many 'moving pieces' to 0.70. If we include it, it should simplify life for users on Windows and generally reduce the API surface of the template (which is always a good idea). If this is a concern for @Kudo or @tomekzaw or others building on top of the template, we can leave this for 0.71. |
|
This pull request was successfully merged by @cortinico in dfd7f70. When will my fix make it into a release? | Upcoming Releases |
there're no concern for us and i like to have cmake for app templates, too 🎉 thanks for the heads up. |
|
ok I'll add it to the list of commits to cherry pick 👍 |
kelset
pushed a commit
that referenced
this pull request
Aug 11, 2022
Summary: Pull Request resolved: #34354 This change simplifies the setup for New Architecture for users on Android. Instead of using the Android.mk file, users can now use a CMake file which encapsulate a lot of the complexities and reduces the maintainance cost. Android.mk support is kept for backward compatibility. Changelog: [Android] [Changed] - Update the new app template to use CMake instead of Android.mk Reviewed By: cipolleschi Differential Revision: D38460536 fbshipit-source-id: 9d4c3b15be751921d34023b24c174044537e6f02
leotm
added a commit
to leotm/react-native-1
that referenced
this pull request
Aug 16, 2022
Follow-up: facebook#34354
leotm
added a commit
to leotm/react-native-1
that referenced
this pull request
Aug 16, 2022
CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: #34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: #34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…ook#34354) Summary: Pull Request resolved: facebook#34354 This change simplifies the setup for New Architecture for users on Android. Instead of using the Android.mk file, users can now use a CMake file which encapsulate a lot of the complexities and reduces the maintainance cost. Android.mk support is kept for backward compatibility. Changelog: [Android] [Changed] - Update the new app template to use CMake instead of Android.mk Reviewed By: cipolleschi Differential Revision: D38460536 fbshipit-source-id: 9d4c3b15be751921d34023b24c174044537e6f02
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: facebook#34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…ook#34354) Summary: Pull Request resolved: facebook#34354 This change simplifies the setup for New Architecture for users on Android. Instead of using the Android.mk file, users can now use a CMake file which encapsulate a lot of the complexities and reduces the maintainance cost. Android.mk support is kept for backward compatibility. Changelog: [Android] [Changed] - Update the new app template to use CMake instead of Android.mk Reviewed By: cipolleschi Differential Revision: D38460536 fbshipit-source-id: 9d4c3b15be751921d34023b24c174044537e6f02
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: facebook#34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: facebook#34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
kelset
pushed a commit
that referenced
this pull request
Aug 22, 2022
Summary: CMake gens running debug - `android/app/.cxx/Debug/*` - `android/app/.cxx/RelWithDebInfo/*` Neither/nothing during release. So probably want the 87 debug files untracked. Follow-up: #34354 _macOS 13b, RN 0.70.0-rc.3_ ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Added] - Update template to gitignore `android/app/.cxx` Pull Request resolved: #34430 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D38752097 Pulled By: cortinico fbshipit-source-id: 61c31317d5e45f831445841f3e14da871b3903e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change simplifies the setup for New Architecture for users on Android.
Instead of using the Android.mk file, users can now use a CMake file which
encapsulate a lot of the complexities and reduces the maintainance cost.
Android.mk support is kept for backward compatibility.
Changelog:
[Android] [Changed] - Update the new app template to use CMake instead of Android.mk
Differential Revision: D38460536