Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][OSS][iOS] Add Matrix tests for Flipper/NoFlipper #34595

Closed
wants to merge 1 commit into from
Closed

[RN][OSS][iOS] Add Matrix tests for Flipper/NoFlipper #34595

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary

This PR adds some tests to verify that we can build the template in every Debug configuration using Flipper and without Flipper.

Changelog

[iOS] [Added] - Add CircleCI tests to verify that we can run the Template with and without Flipper

Test Plan

CircleCI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 5, 2022
@cipolleschi cipolleschi force-pushed the feat/use_flipper_yes_no branch 2 times, most recently from 63e23a7 to a6edc8e Compare September 5, 2022 14:24
@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Sep 5, 2022
@cipolleschi cipolleschi force-pushed the feat/use_flipper_yes_no branch 4 times, most recently from 805c8d9 to d6075b6 Compare September 5, 2022 14:32
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,637,088 +53
android hermes armeabi-v7a 7,049,083 +61
android hermes x86 7,939,047 +40
android hermes x86_64 7,911,074 +45
android jsc arm64-v8a 9,513,254 +36
android jsc armeabi-v7a 8,288,554 +50
android jsc x86 9,452,796 +18
android jsc x86_64 10,044,044 +37

Base commit: 5c109b3
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5c109b3
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mikehardy
mikehardy approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing this stuff. This looks good to me
What follows is no criticism it's just excitement for future - now just hoping for macCatalyst and use_frameworks :-)

🚂

@cipolleschi
Copy link
Contributor Author

What follows is no criticism it's just excitement for future - now just hoping for macCatalyst and use_frameworks :-)

Yup, baby steps! :D

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in bf6a24b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 6, 2022
@yungsters yungsters deleted the feat/use_flipper_yes_no branch September 29, 2022 16:16
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@OlimpiaZurek
Add Matrix tests for Flipper/NoFlipper (facebook#34595)
f9c3a69 
Summary:
This PR adds some tests to verify that we can build the template in every Debug configuration using Flipper and without Flipper.

## Changelog

[iOS] [Added] - Add CircleCI tests to verify that we can run the Template with and without Flipper

Pull Request resolved: facebook#34595

Test Plan: CircleCI is green

Reviewed By: cortinico

Differential Revision: D39262137

Pulled By: cipolleschi

fbshipit-source-id: dae45b106cd13fb69442ea216005cee114d861f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@hramos hramos Awaiting requested review from hramos

@cortinico cortinico Awaiting requested review from cortinico

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipolleschi @analysis-bot @facebook-github-bot @react-native-bot @mikehardy