Fixing failure building RN codegen CLI on Windows #34791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e characters from being interpreted as ASCII escape characters.
facebook-github-bot
added
CLA Signed
Base commit: 8cdc9e7 |
mganandraj
changed the title
mganandraj
changed the title
Base commit: 3f3394a |
cortinico
approved these changes
Sep 27, 2022
|
Done .. The other errors seems unrelated to this change. |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mganandraj in 85c0c0f. When will my fix make it into a release? | Upcoming Releases |
1 similar comment
|
This pull request was successfully merged by @mganandraj in 85c0c0f. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Oct 11, 2022
Summary: Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. ## Changelog Fixing build failure building RN codegen CLI on Windows. Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. [Android] [Fixed] - Fixing failure building RN codegen CLI on Windows Pull Request resolved: #34791 Test Plan: Ensured RN main branch builds on Windows with new architecture turned on. Reviewed By: cipolleschi Differential Revision: D39889468 Pulled By: cipolleschi fbshipit-source-id: 7d79eac9f433908cc86dd7ca2eec841739ef6365 # Conflicts: # ReactAndroid/cmake-utils/ReactNative-application.cmake
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. ## Changelog Fixing build failure building RN codegen CLI on Windows. Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. [Android] [Fixed] - Fixing failure building RN codegen CLI on Windows Pull Request resolved: facebook#34791 Test Plan: Ensured RN main branch builds on Windows with new architecture turned on. Reviewed By: cipolleschi Differential Revision: D39889468 Pulled By: cipolleschi fbshipit-source-id: 7d79eac9f433908cc86dd7ca2eec841739ef6365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters.
Summary
Changelog
Fixing build failure building RN codegen CLI on Windows. Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters.
[Android] [Fixed] - Fixing failure building RN codegen CLI on Windows
Test Plan
Ensured RN main branch builds on Windows with new architecture turned on.