Fix forward: Filtering platform in codegen #34897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This [commit](facebook@7680bde) added the possibility to create a Codegen specs that are platform specific. However, it also modifies how the codegen is invoked and we need to publish a new version of the `react-native-codegen` package on NPM before we can use that feature. ## CHANGELOG [General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen. Differential Revision: D40176447 fbshipit-source-id: c1e169e7f128aaf3d009ad8fb78a52718192a94d
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40176447 |
Base commit: 2afcea2 |
Base commit: 2afcea2 |
|
This pull request was successfully merged by @cipolleschi in ae3dd54. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34897 This [commit](facebook@7680bde) added the possibility to create Codegen specs that are platform specific. However, it also modifies how the codegen is invoked and we need to publish a new version of the `react-native-codegen` package on NPM before we can use that feature. ## Changelog: [General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen. Reviewed By: robhogan Differential Revision: D40176447 fbshipit-source-id: 20be630dec3dcd7efb9fd510c6cf9f2c161f906a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit added the possibility to create a Codegen specs that are platform specific.
However, it also modifies how the codegen is invoked and we need to publish a new version of the
react-native-codegenpackage on NPM before we can use that feature.Changelog:
[General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen.
Differential Revision: D40176447