fix RCTNetworking contentType issue #35640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 9f9111b |
Base commit: 83afdaf |
|
PR build artifact for fb63097 is ready. |
|
PR build artifact for fb63097 is ready. |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmytrorykun merged this pull request in c0834b8. |
Closed
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: https://github.com/facebook/react-native/blob/96027f787ade1a465569975059426d2c03ee5ad0/Libraries/Network/RCTNetworking.mm#L418 because `RCTNullIfNil(response.MIMEType)`, `contentType` may be `[NSNull null]` https://github.com/facebook/react-native/blob/96027f787ade1a465569975059426d2c03ee5ad0/Libraries/Network/RCTNetworking.mm#L114 Here only check `partContentType` is not nil, This causes the custom type never used https://github.com/facebook/react-native/blob/96027f787ade1a465569975059426d2c03ee5ad0/Libraries/Network/RCTNetworking.mm#L334 more serious here, if `dataContentType` is `[NSNull null]` , it will crash the application `-[NSNull hasPrefix:]: unrecognized selector sent to instance 0x7fff8004b700` ## Changelog [iOS] [Fixed] - fix dataContentType may be [NSNull null] issue Pull Request resolved: facebook#35640 Reviewed By: cipolleschi Differential Revision: D42067206 Pulled By: dmytrorykun fbshipit-source-id: 073e6589111f5117486b69b8206a07ef1995c5b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-native/Libraries/Network/RCTNetworking.mm
Line 418 in 96027f7
because
RCTNullIfNil(response.MIMEType),contentTypemay be[NSNull null]react-native/Libraries/Network/RCTNetworking.mm
Line 114 in 96027f7
Here only check
partContentTypeis not nil, This causes the custom type never usedreact-native/Libraries/Network/RCTNetworking.mm
Line 334 in 96027f7
more serious here, if
dataContentTypeis[NSNull null], it will crash the application-[NSNull hasPrefix:]: unrecognized selector sent to instance 0x7fff8004b700Changelog
[iOS] [Fixed] - fix dataContentType may be [NSNull null] issue
Test Plan