rename App-test.tsx to App.test.tsx #35826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 8befb74 |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
approved these changes
Jan 16, 2023
cortinico
approved these changes
Jan 16, 2023
|
@NickGerleman merged this pull request in 3c03aef. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: The starter test file when creating a `create-react-app` project is `App.test.js`, while in react-native its `App-test.js`_(recently changed to `.tsx` instead of `.js`)_ This aims to unify the naming convention between `create-react-app` and `react-native init`. Originally suggested here: react-native-community/discussions-and-proposals#570 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [CHANGED] - Renamed App-test.tsx to App.test.tsx to unify naming convention with create-react-app Pull Request resolved: facebook#35826 Test Plan: 1. cd template 2. yarn 3. yarn test The test inside `__tests__/App.test.tsx` should (still) pass Reviewed By: cipolleschi Differential Revision: D42527535 Pulled By: NickGerleman fbshipit-source-id: 5247c5a65760973afe39a4b37abb5a6b52c1fadc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The starter test file when creating a
create-react-appproject isApp.test.js, while in react-native itsApp-test.js(recently changed to.tsxinstead of.js)This aims to unify the naming convention between
create-react-appandreact-native init.Originally suggested here: react-native-community/discussions-and-proposals#570
Changelog
[GENERAL] [CHANGED] - Renamed App-test.tsx to App.test.tsx to unify naming convention with create-react-app
Test Plan
The test inside
__tests__/App.test.tsxshould (still) pass