Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#36475] A fix in Codegen for Windows build host #36542

Closed
wants to merge 3 commits into from
Closed

[#36475] A fix in Codegen for Windows build host #36542

wants to merge 3 commits into from

Conversation

birdofpreyru
Copy link
Contributor

@birdofpreyru birdofpreyru commented Mar 20, 2023 •
edited
Loading

Summary

Android builds with new arch fail on Windows build host (#36475). This tiny correction fixes generation of schema.json (without it codegen failed to find any files, and generated empty schema). Unfortunately, does not fixes the issue with Windows host entirely, as builds still fail later (on ninja build step).

Changelog:

[Android] [Fixed] - A bug fix for Android builds with new arch on Windows host.

Test Plan

@facebook-github-bot
Copy link
Contributor

Hi @birdofpreyru!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

analysis-bot commented Mar 20, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,071 -740
android hermes armeabi-v7a 7,834,632 -790
android hermes x86 8,998,959 -1,318
android hermes x86_64 8,853,983 -1,350
android jsc arm64-v8a 9,141,891 -470
android jsc armeabi-v7a 8,333,499 -520
android jsc x86 9,196,473 -1,039
android jsc x86_64 9,454,278 -1,095

Base commit: fdb2af5
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

5 similar comments
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@cortinico
Copy link
Contributor

Thanks for the fix @birdofpreyru
Can we fix the tests though as they're failing exactly at the line you added

@birdofpreyru
Copy link
Contributor Author

Can we fix the tests though as they're failing exactly at the line you added

Yeap, saw it, will do later.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@cortinico
Copy link
Contributor

@birdofpreyru please let me know if you want me to do another review here

@birdofpreyru
Copy link
Contributor Author

@cortinico yes, please.

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

This pull request was successfully merged by @birdofpreyru in a323249.

When will my fix make it into a release? | Upcoming Releases

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 22, 2023
@github-actions github-actions bot added the Merged This PR has been merged. label Aug 22, 2023
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in a323249.

fortmarek pushed a commit that referenced this pull request Sep 4, 2023
@birdofpreyru @fortmarek
A fix in Codegen for Windows build host (#36542)
66441e7 
Summary:
Android builds with new arch fail on Windows build host (#36475). This tiny correction fixes generation of `schema.json` (without it codegen failed to find any files, and generated empty schema). Unfortunately, does not fixes the issue with Windows host entirely, as builds still fail later (on ninja build step).

## Changelog:
[Android] [Fixed] - A bug fix for Android builds with new arch on Windows host.

Pull Request resolved: #36542

Reviewed By: NickGerleman

Differential Revision: D48563587

Pulled By: cortinico

fbshipit-source-id: acd510308ce9768fb17d3a33c7927de3237748ac
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 12, 2023
Merged
@NOUIY NOUIY mentioned this pull request Oct 16, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
@NOUIY NOUIY mentioned this pull request Nov 4, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@birdofpreyru @facebook-github-bot @analysis-bot @cortinico