Re-enable Fabric in the default app template/RN-Tester #36717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44536222 |
|
This pull request was exported from Phabricator. Differential Revision: D44536222 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 30, 2023
Summary: Pull Request resolved: facebook#36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: b20a8099077db46e6ef8b22cc7bb1d48dd100c38
cortinico
force-pushed
the
export-D44536222
branch
from
3b7be27
to
7ce2ed1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44536222 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 30, 2023
Summary: Pull Request resolved: facebook#36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: e47da837eea569d52f912de1165bc5d5aa42f7f3
cortinico
force-pushed
the
export-D44536222
branch
from
7ce2ed1
to
dc6f416
Compare
Base commit: 66ae98e |
Summary: Pull Request resolved: facebook#36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: febbca88fae213516e03e3c7a4d55e76a01e020e
cortinico
force-pushed
the
export-D44536222
branch
from
dc6f416
to
8664116
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44536222 |
|
This pull request has been merged in e5dd9cd. |
kelset
pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: Pull Request resolved: #36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: d22a0c522f011a8fe4d27b5d8f2fcf5dd13c3058
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: d22a0c522f011a8fe4d27b5d8f2fcf5dd13c3058
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36717 After D43711737 landed, it turns out that Fabric is always disabled for both RN-Tester and new app from template (so for 0.72 also RC0). The reason is that a new method `createRootView(Bundle)` was introduced inside `ReactActivityDelegate`. Both RN Tester and the template were using the old `createRootView()` method which is not called anymore at this stage (should potentially be deprecated?). This diff fixes it by overriding both method inside `DefaultReactActivityDelegate` so that both methods are setting the Fabric renderer. Changelog: [Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester Reviewed By: cipolleschi Differential Revision: D44536222 fbshipit-source-id: d22a0c522f011a8fe4d27b5d8f2fcf5dd13c3058
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After D43711737 landed, it turns out that Fabric is always disabled for both
RN-Tester and new app from template (so for 0.72 also RC0).
The reason is that a new method
createRootView(Bundle)was introduced insideReactActivityDelegate. Both RN Tester and the template were using theold
createRootView()method which is not called anymore at this stage(should potentially be deprecated?).
This diff fixes it by overriding both method inside
DefaultReactActivityDelegateso that both methods are setting the Fabric renderer.
Changelog:
[Android] [Fixed] - Re-enable Fabric in the default app template/RN-Tester
Differential Revision: D44536222