Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xcode): backport Xcode 14.3 fix to 70 #36768

Merged
merged 2 commits into from
Apr 3, 2023
Merged

fix(xcode): backport Xcode 14.3 fix to 70 #36768

merged 2 commits into from
Apr 3, 2023

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Apr 3, 2023

Summary:

A quick attempt at a minimal fix for 0.70 for #36739, based on #36759

Changelog:

[IOS] [FIXED] - Fix React Codegen podspec to build on Xcode 14.3

Test Plan:

@kelset kelset requested a review from cipolleschi April 3, 2023 10:19
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Apr 3, 2023
cipolleschi
cipolleschi requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update also codegen_utils-test.rb, otherwise the CI is red.

.circleci/config.yml Outdated Show resolved Hide resolved
@kelset kelset requested a review from cipolleschi April 3, 2023 10:44
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: cb88e75
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,596,765 -972,244
android hermes armeabi-v7a 7,015,291 -868,109
android hermes x86 7,898,000 -1,152,927
android hermes x86_64 7,869,799 -1,036,155
android jsc arm64-v8a 9,478,152 +310,421
android jsc armeabi-v7a 8,258,746 -99,386
android jsc x86 9,417,499 +193,101
android jsc x86_64 10,008,733 +526,497

Base commit: cb88e75
Branch: main

@cipolleschi cipolleschi mentioned this pull request Apr 3, 2023
Closed
@kelset kelset mentioned this pull request Apr 3, 2023
Closed
@kelset kelset merged commit 34f3794 into 0.70-stable Apr 3, 2023
@kelset kelset deleted the kelset/backport-xcode-143-fix-070 branch April 3, 2023 13:51
@AlixH AlixH mentioned this pull request May 15, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Closed
@cipolleschi cipolleschi mentioned this pull request Dec 19, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kelset @analysis-bot @cipolleschi @facebook-github-bot