Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin #37374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
Base commit: 8d3df56 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
…#37374) Summary: Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: f6b3b0c3d842fee7854ccd8c284ef89624a1a42a
NickGerleman
force-pushed
the
export-D45766764
branch
from
332700f
to
356630c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
…#37374) Summary: Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: ad948c5a973ab97b17f3c4bb83573106fa4017c0
NickGerleman
force-pushed
the
export-D45766764
branch
from
356630c
to
d8039d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
NickGerleman
force-pushed
the
export-D45766764
branch
from
d8039d3
to
26dffb8
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
…#37374) Summary: Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: 3dadeda00ab437c5d313beadfe797d32b43d1a93
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
NickGerleman
force-pushed
the
export-D45766764
branch
from
26dffb8
to
799b94e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 28, 2023
…#37374) Summary: Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: a10bb59e2d74821b40f36ccd7863cf51890235f9
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jun 28, 2023
Summary: X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: a779190e997bb7aa8cce2dfee58a58f8f0cab56e
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jun 28, 2023
…#1317) Summary: Pull Request resolved: facebook#1317 X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: 9a7a23842335bffafa573c164a166b9ab8080160
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 28, 2023
…#37374) Summary: X-link: facebook/yoga#1317 Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: cfa97bc2006815b0ae4393cdc0853967f54c3080
NickGerleman
force-pushed
the
export-D45766764
branch
from
799b94e
to
f054a38
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
…#37374) Summary: X-link: facebook/yoga#1317 Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: ee0a03469fde75298277e9553957e7436cedeacc
NickGerleman
force-pushed
the
export-D45766764
branch
from
f054a38
to
9d142d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jun 29, 2023
Summary: X-link: facebook/yoga#1317 X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jun 29, 2023
Summary: Pull Request resolved: #1317 X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
|
This pull request was successfully merged by @NickGerleman in 3f6412b. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).
Differential Revision: D45766764