Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel-runtime version #37457

Closed
wants to merge 1 commit into from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 17, 2023

Summary:

Inconsistent @babel/runtime version after 0.72.
On 0.71, it was aligned to ^7.20.0
From 0.72, it was downgraded to ^7.12.5
this might be coming from monorepo movement.

Changelog:

[GENERAL] [FIXED] - Aligned @babel/runtime version to ^7.20.0

Test Plan:

ci passed

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels May 17, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,587 -2
android hermes armeabi-v7a 8,043,934 +2
android hermes x86 9,221,944 +1
android hermes x86_64 9,074,913 +2
android jsc arm64-v8a 9,297,788 -1
android jsc armeabi-v7a 8,486,556 -1
android jsc x86 9,358,525 -2
android jsc x86_64 9,615,113 +0

Base commit: a310217
Branch: main

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hoxyq
Copy link
Contributor

hoxyq commented May 17, 2023

This is not related to monorepo work, this is because #35786 was never backported into the main branch.

There was an attempt in #35787, but we completely missed it.

@Kudo
Copy link
Contributor Author

Kudo commented May 17, 2023

good to know, thanks @hoxyq. i'm closing this pr in favor of #35787

@Kudo Kudo closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants