Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tm-android): Reject Promise if Turbo Module method throws an Error #37484

Closed
wants to merge 52 commits into from
Closed

feat(tm-android): Reject Promise if Turbo Module method throws an Error #37484

wants to merge 52 commits into from

Commits on Apr 27, 2023

  1. Add iOS reject promise if turbo module method throws exception

    @krystofwoldrich
    krystofwoldrich committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    097525d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Merge remote-tracking branch 'origin/main' into kw-mixed-stack-traces… 

    …-promise
    @krystofwoldrich
    krystofwoldrich committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4fc71fd View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Merge remote-tracking branch 'origin/main' into kw-mixed-stack-traces… 

    …-promise
    @krystofwoldrich
    krystofwoldrich committed May 14, 2023
    Configuration menu
    Copy the full SHA
    108e205 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge branch 'main' into kw-mixed-stack-traces-promise

    @krystofwoldrich
    krystofwoldrich committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0ca58bb View commit details
    Browse the repository at this point in the history

  2. Add Android reject async func on error

    @krystofwoldrich
    krystofwoldrich committed May 15, 2023
    Configuration menu
    Copy the full SHA
    5892e50 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. add(ios): js stack to rejection caused by native exception or native … 

    …rejection
    @krystofwoldrich
    krystofwoldrich committed May 16, 2023
    Configuration menu
    Copy the full SHA
    97606c9 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Fix android promise reject and add JS stack trace

    @krystofwoldrich
    krystofwoldrich committed May 17, 2023
    Configuration menu
    Copy the full SHA
    2eb0a46 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Refactor java callback

    @krystofwoldrich
    krystofwoldrich committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a836691 View commit details
    Browse the repository at this point in the history

  2. Fix typos

    @krystofwoldrich
    krystofwoldrich committed May 18, 2023
    Configuration menu
    Copy the full SHA
    be2ea63 View commit details
    Browse the repository at this point in the history

  3. iOS jsStack do not copy

    @krystofwoldrich
    krystofwoldrich committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ccf5460 View commit details
    Browse the repository at this point in the history

  4. Update lint

    @krystofwoldrich
    krystofwoldrich committed May 18, 2023
    Configuration menu
    Copy the full SHA
    85f48d7 View commit details
    Browse the repository at this point in the history

  5. More lint

    @krystofwoldrich
    krystofwoldrich committed May 18, 2023
    Configuration menu
    Copy the full SHA
    7205f1d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge remote-tracking branch 'upstream/main' into kw-mixed-stack-trac… 

    …es-promise
    @krystofwoldrich
    krystofwoldrich committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d92339c View commit details
    Browse the repository at this point in the history

  2. Add RCT_TRACE_PROMISE_REJECTION_ENABLED flag for iOS

    @krystofwoldrich
    krystofwoldrich committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    99cb0b9 View commit details
    Browse the repository at this point in the history

  3. Rename the iOS flag

    @krystofwoldrich
    krystofwoldrich committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    732dba9 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add android flag and fix internal reject invocation on Hermes

    @krystofwoldrich
    krystofwoldrich committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    239667d View commit details
    Browse the repository at this point in the history

  2. move RCTInternalPromiseRejectBlock to rct turbo module

    @krystofwoldrich
    krystofwoldrich committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    882c81b View commit details
    Browse the repository at this point in the history

  3. Add js func returning void rethrow explanation

    @krystofwoldrich
    krystofwoldrich committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9529dd9 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Rename RCTInternalPromiseRejectBlock to RCTNSExceptionHandler

    @krystofwoldrich
    krystofwoldrich committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    40163ff View commit details
    Browse the repository at this point in the history

  2. Add CallbackWrapperExecutor type

    @krystofwoldrich
    krystofwoldrich committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    49b861d View commit details
    Browse the repository at this point in the history

  3. Handle all throws from Obj-Cpp

    @krystofwoldrich
    krystofwoldrich committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4d40ceb View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge remote-tracking branch 'upstream/main' into kw-mixed-stack-trac… 

    …es-promise
    @krystofwoldrich
    krystofwoldrich committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    86bf079 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into kw-mixed-stack-traces-promise

    @krystofwoldrich
    krystofwoldrich committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b21990c View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Enable trace turbo module rejection in debug iOS builds

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    25b32b7 View commit details
    Browse the repository at this point in the history

  2. Make jsInvocationStack optional

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    be8e027 View commit details
    Browse the repository at this point in the history

  3. Add jsInvocationStack comment

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    377c328 View commit details
    Browse the repository at this point in the history

  4. use ref to js stack in createRejectJSErrorValue

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6e4b652 View commit details
    Browse the repository at this point in the history

  5. Use only one rejectJSIFn in java

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    abf7e8a View commit details
    Browse the repository at this point in the history

  6. Rename feature flag

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e1634a6 View commit details
    Browse the repository at this point in the history

  7. fix flag func overload

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    65982e2 View commit details
    Browse the repository at this point in the history

  8. Update feature flag

    @krystofwoldrich
    krystofwoldrich committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ba06a6e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge commit '60f5a80c1d5900e5213aabd3d3a762174996cfd1' into kw-mixed… 

    …-stack-traces-promise
    @krystofwoldrich
    krystofwoldrich committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c6dd575 View commit details
    Browse the repository at this point in the history

  2. enable tracing turbo modules promises rejections in debug

    @krystofwoldrich
    krystofwoldrich committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2a3f8ea View commit details
    Browse the repository at this point in the history

  3. unify naming

    @krystofwoldrich
    krystofwoldrich committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bd9b7f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Use jsi types for callback executor

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3f81d5a View commit details
    Browse the repository at this point in the history

  2. access cause safe

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1936174 View commit details
    Browse the repository at this point in the history

  3. keep js invocation stack as property

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    975a511 View commit details
    Browse the repository at this point in the history

  4. Hold reference to stack to avoid parsing string

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bf584da View commit details
    Browse the repository at this point in the history

  5. Add explanation comment

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3937f61 View commit details
    Browse the repository at this point in the history

  6. Add test errors logs for easier verification

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c735ba9 View commit details
    Browse the repository at this point in the history

  7. Add rejectTurboModulePromiseOnNativeError flag

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7e84c08 View commit details
    Browse the repository at this point in the history

  8. Drop iOS changes

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f0f515b View commit details
    Browse the repository at this point in the history

  9. One more header

    @krystofwoldrich
    krystofwoldrich committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7359585 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into kw-mixed-stack-trac… 

    …es-promise
    @krystofwoldrich
    krystofwoldrich committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0025fbd View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. review fixes, remove build config, unwrap callback executor, safe han… 

    …dle exception_ptr
    @krystofwoldrich
    krystofwoldrich committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    422f10f View commit details
    Browse the repository at this point in the history

  2. Remove unused var

    @krystofwoldrich
    krystofwoldrich committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b0a1ed5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge remote-tracking branch 'upstream/main' into kw-mixed-stack-trac… 

    …es-promise
    @krystofwoldrich
    krystofwoldrich committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    26683c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Use async callback WIP -> returns undefined

    @krystofwoldrich
    krystofwoldrich committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fdbde12 View commit details
    Browse the repository at this point in the history

  2. Clean up, fix reject index, revert stack to string add comments

    @krystofwoldrich
    krystofwoldrich committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d545623 View commit details
    Browse the repository at this point in the history

  3. trace rejection based on debug config flag

    @krystofwoldrich
    krystofwoldrich committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d77f909 View commit details
    Browse the repository at this point in the history

  4. Update based on comments

    @krystofwoldrich
    krystofwoldrich committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bc505bf View commit details
    Browse the repository at this point in the history

  5. Use global ref for throwable

    @krystofwoldrich
    krystofwoldrich committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e99fb6a View commit details
    Browse the repository at this point in the history