Add support for building with Xcode 15 #37758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
approved these changes
Jun 7, 2023
| .each do |pod_name, target_installation_result| | ||
| target_installation_result.native_target.build_configurations.each do |config| | ||
| # unary_function and binary_function are no longer provided in C++17 and newer standard modes as part of Xcode 15. | ||
| # They can be re-enabled with setting _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION |
There was a problem hiding this comment.
nit: could you add a link to the Xcode doc about this point?
There was a problem hiding this comment.
Do you mean pointing to https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations for future reference?
There was a problem hiding this comment.
@cipolleschi I have added the link to that part of the code. Let me know if you prefer pointing to a different URL.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: e449706 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 10d5588. |
kelset
pushed a commit
that referenced
this pull request
Jun 13, 2023
Summary: Fixes #37748 This PR adds a patch which fixes a build issue in Xcode 15. ## Changelog: [IOS] [ADDED] - Add support for building with Xcode 15 Pull Request resolved: #37758 Reviewed By: cortinico Differential Revision: D46524009 Pulled By: cipolleschi fbshipit-source-id: 9f6c12e12a15c154467282a7b4a00e80e5cc0af2
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Fixes facebook#37748 This PR adds a patch which fixes a build issue in Xcode 15. ## Changelog: [IOS] [ADDED] - Add support for building with Xcode 15 Pull Request resolved: facebook#37758 Reviewed By: cortinico Differential Revision: D46524009 Pulled By: cipolleschi fbshipit-source-id: 9f6c12e12a15c154467282a7b4a00e80e5cc0af2 (cherry picked from commit 8ed2cfd)
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #37748
This PR adds a patch which fixes a build issue in Xcode 15.
Changelog:
[IOS] [ADDED] - Add support for building with Xcode 15
Test Plan: