Remove CallInvoker parameter from toJs method in Codegen #37832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46647110 |
Base commit: ef5d92f |
) Summary: Pull Request resolved: facebook#37832 This parameter is currently unused and is causing Android builds to fail as they compile with `-Wall` This is a follow-up to facebook#37454 as that PR updated only the `fromJs` and not the `toJs` method as well. Changelog: [Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen Reviewed By: rshest Differential Revision: D46647110 fbshipit-source-id: c5a279a5acb9682ca041833b888e10146a79c4d8
cortinico
force-pushed
the
export-D46647110
branch
from
3e0a56b
to
d18b60d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46647110 |
|
This pull request has been merged in 3a246ed. |
kelset
pushed a commit
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: #37832 This parameter is currently unused and is causing Android builds to fail as they compile with `-Wall` This is a follow-up to #37454 as that PR updated only the `fromJs` and not the `toJs` method as well. Changelog: [Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen Reviewed By: rshest Differential Revision: D46647110 fbshipit-source-id: 1f3e22aca7a3df11ac02b5c4b89c9311b8b1798c
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 15, 2023
) Summary: Pull Request resolved: facebook#37832 This parameter is currently unused and is causing Android builds to fail as they compile with `-Wall` This is a follow-up to facebook#37454 as that PR updated only the `fromJs` and not the `toJs` method as well. Changelog: [Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen Reviewed By: rshest Differential Revision: D46647110 fbshipit-source-id: 1f3e22aca7a3df11ac02b5c4b89c9311b8b1798c (cherry picked from commit 0da7e06)
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This parameter is currently unused and is causing Android builds to fail
as they compile with
-WallThis is a follow-up to #37454 as that PR updated only the
fromJsand not thetoJsmethod as well.Changelog:
[Internal] [Changed] - Remove CallInvoker parameter from toJs method in Codegen
Differential Revision: D46647110