W3CPointerEvents: include modifier key properties in Android pointer events #38197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47162963 |
Base commit: f6c91bf |
…events (facebook#38197) Summary: Pull Request resolved: facebook#38197 Changelog: [Android] [Fixed] - W3CPointerEvents: include modifier key properties in Android pointer events The [spec](https://www.w3.org/TR/uievents/#idl-mouseevent) says there should be properties on mouse events (and hence pointer events) indicating whether ctrl, alt, shift, and/or meta are pressed during the event. This change adds those properties. Reviewed By: javache Differential Revision: D47162963 fbshipit-source-id: 357cae32b6c02206967f4992f533c2ac7c1d8907
|
This pull request was exported from Phabricator. Differential Revision: D47162963 |
|
This pull request has been merged in 2bd4429. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android] [Fixed] - W3CPointerEvents: include modifier key properties in Android pointer events
The spec says there should be properties on mouse events (and hence pointer events) indicating whether ctrl, alt, shift, and/or meta are pressed during the event.
This change adds those properties.
Reviewed By: javache
Differential Revision: D47162963