Return NONE accessibility role if null is passed.
#38613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
Base commit: 0f48e86 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: 075972ccc7bdbed8737f2c3a27add0cc398ef1d4
cipolleschi
force-pushed
the
export-D47752098
branch
from
54a75de
to
032c22d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: 4fd519baca3787cc7a420f9fadd04626f59e7af2
cipolleschi
force-pushed
the
export-D47752098
branch
from
032c22d
to
c2f5d81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: 75406f5849261346db5ff4e64432b34e62fcc121
cipolleschi
force-pushed
the
export-D47752098
branch
from
c2f5d81
to
e2fa531
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: e32eb5620dc097a8ba6eda2539ce3e97e39bb373
cipolleschi
force-pushed
the
export-D47752098
branch
from
e2fa531
to
9ad1bc7
Compare
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: b33b39c4c9fe95b59581569d32bc408c864bab52
|
This pull request was exported from Phabricator. Differential Revision: D47752098 |
cipolleschi
force-pushed
the
export-D47752098
branch
from
9ad1bc7
to
315c76b
Compare
|
This pull request was successfully merged by @cipolleschi in 0f48e86. When will my fix make it into a release? | Upcoming Releases |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: e8a44bdd8874e996d8127cb2ee29e5135210b196
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: e8a44bdd8874e996d8127cb2ee29e5135210b196
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38613 The `value` string of the ReactAccessibilityDelegate's `fromValue` method is marked as `Nullable`, however the `null` case is not handled. This change handle the `null` case setting the accesssibility role to NONE. ## Changelog: [Android][Fixed] - Set the accessibility role to `NONE` when a `null` string is passed to `fromValue` Reviewed By: cortinico Differential Revision: D47752098 fbshipit-source-id: e8a44bdd8874e996d8127cb2ee29e5135210b196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
valuestring of the ReactAccessibilityDelegate'sfromValuemethod is marked asNullable, however thenullcase is not handled.This change handle the
nullcase setting the accesssibility role to NONE.Changelog:
[Android][Fixed] - Set the accessibility role to
NONEwhen anullstring is passed tofromValueDifferential Revision: D47752098