Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CustomLineHeightSpanTest to kotlin #38847

Closed
wants to merge 1 commit into from
Closed

Migrate CustomLineHeightSpanTest to kotlin #38847

wants to merge 1 commit into from

Conversation

tarunrajput
Copy link
Contributor

Summary:

Migrate CustomLineHeightSpanTest to kotlin as part of ☂️ #38825

Changelog:

[Internal] [Changed] - Migrate CustomLineHeightSpanTest to kotlin

Test Plan:

./gradlew :packages:react-native:ReactAndroid:test

@analysis-bot
Copy link

analysis-bot commented Aug 8, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,894,948 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,486,847 -2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 798811c
Branch: main

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 8, 2023
cortinico
cortinico reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Just a minor change to apply to all the tests for the sake of being more Kotlin-idiomatic.

Thank you again for doing this @tarunrajput

...-native/ReactAndroid/src/test/java/com/facebook/react/views/text/CustomLineHeightSpanTest.kt Outdated Show resolved Hide resolved
@tarunrajput tarunrajput force-pushed the migrate-CustomLineHeightSpanTest-to-kt branch from 9b69f4a to d5ce7b4 Compare August 8, 2023 16:05
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request was successfully merged by @tarunrajput in 4343144.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarunrajput @analysis-bot @facebook-github-bot @cortinico