Fixes regression of prop parsing for elevation #38959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: mdvacca Differential Revision: D48269510 fbshipit-source-id: 26dbc7dbdcaadb3dad537226656abd9aee4d05a9
rozele
force-pushed
the
export-D48269510
branch
from
a4b3118
to
ec42ae0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: mdvacca Differential Revision: D48269510 fbshipit-source-id: 9491a23103efe3a5b7314de7bfce17f9f5772138
rozele
force-pushed
the
export-D48269510
branch
from
ec42ae0
to
8ecf41a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: mdvacca Differential Revision: D48269510 fbshipit-source-id: 336fad2fd53689102be80624e2b6c71d6d43c24b
rozele
force-pushed
the
export-D48269510
branch
from
8ecf41a
to
6f1df3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: mdvacca Differential Revision: D48269510 fbshipit-source-id: 615b12fff6ed0abe0a0e43cd80559f4dbc43a812
rozele
force-pushed
the
export-D48269510
branch
from
6f1df3b
to
bd1755c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: sammy-SC, mdvacca Differential Revision: D48269510 fbshipit-source-id: 240057665bd006b249ac7f95d231ec8d9fe42d5f
rozele
force-pushed
the
export-D48269510
branch
from
bd1755c
to
cf936d1
Compare
Base commit: dea9c35 |
Summary: Pull Request resolved: facebook#38959 When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Reviewed By: sammy-SC, mdvacca Differential Revision: D48269510 fbshipit-source-id: 2d35331639e2e7d850548e2dc93a16abb61e4735
|
This pull request was exported from Phabricator. Differential Revision: D48269510 |
rozele
force-pushed
the
export-D48269510
branch
from
cf936d1
to
50fa5ae
Compare
|
This pull request has been merged in 68c7cfe. |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 12, 2023
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: 52dac650e0ca43ef094d28f5df4388bc98e20fb9
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 12, 2023
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: d9c8b2d1b01ecf6532e92ef6dbce0a5be9c2b57b
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 12, 2023
…book#38973) Summary: Pull Request resolved: facebook#38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When facebook#38674 and facebook#38959 are combined, they cause Android apps on Fabric to crash. facebook#38959 is the more urgent fix, so backing out facebook#38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: a3f8efe9bb2657a420a6af7f6b52af37e28d3f3f
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 12, 2023
Summary: Pull Request resolved: #38973 Original commit changeset: 6c00c2fcfdfd Original Phabricator Diff: D47852371 When #38674 and #38959 are combined, they cause Android apps on Fabric to crash. #38959 is the more urgent fix, so backing out #38674. ## Changelog: [General] [Fixed] - Rolling back change that broke e2e tests until we can figure out why the e2e tests are broken Reviewed By: NickGerleman Differential Revision: D48288752 fbshipit-source-id: b52e28936bbebd21bd3b2f49f9a233f295ba6248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When refactoring ViewProps in D47492635,
elevationprop parsing was dropped. This restores it.Changelog:
[General] [Fixed] - Fabric regression for elevation prop in Android
Differential Revision: D48269510