Fix inverted contentOffset in scroll events in RTL
#39031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D29164056 fixed `scrollTo` coordinate space in RTL, but D38499666 regressed it by adding a comparison before the RTL conversion happens. This makes `scrollTo` no-op if we are scrolling from the beginning to the end of the list, since the end of the list is `x: 0` in cartesian coordinates, and the start of the list is `x: 0` in flow-relative coordinates. Do coordinate conversion before the early exit check. Changelog: [iOS][Fixed] - Fix bad comparison in RCTScrollViewComponentView RTL Differential Revision: D48378414 fbshipit-source-id: edef543bab9612bb61176a7cda259f18ad6e8c45
Summary: `UIScrollView` `contentOffset` is flow-relative, so `x` is relative to the right edge of the screen. This coordinate space disagrees with layout events, `scrollTo` coordinates, and other platforms. This applies the same logic we use for inverting `scrollTo` coordinates to invert `contentOffset` in scroll events, in both Paper and Fabric. We then remove the iOS specific workaround we have in VirtualizedList. Differential Revision: D48379915 fbshipit-source-id: caa48b99d43298cf51e5d668dd7e7f68fee2ec4e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48379915 |
Base commit: 5063871 |
|
This pull request has been merged in 4f8a8ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
UIScrollViewcontentOffsetis flow-relative, soxis relative to the right edge of the screen. This coordinate space disagrees with layout events,scrollTocoordinates, and other platforms.This applies the same logic we use for inverting
scrollTocoordinates to invertcontentOffsetin scroll events, in both Paper and Fabric. We then remove the iOS specific workaround we have in VirtualizedList.Differential Revision: D48379915