Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flipper actions in Dev Menu, add new Open Debugger action (Android) #39254

Closed
wants to merge 3 commits into from

Conversation

huntie
Copy link
Member

@huntie huntie commented Sep 1, 2023

Summary:

Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

Changes

  • Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
  • Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Differential Revision: D46187942

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

@analysis-bot
Copy link

analysis-bot commented Sep 1, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,341,622 -431
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,580,361 -467
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d208dc4
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Differential Revision: D46187942

fbshipit-source-id: 1304a7e00cc8a3ca8f69e6e1fab3943357129850
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: bc21f70eff86bfca81fdc4f3e77953b2b9e34651
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: 95e87737f254af6d22ae1e2734cba6a324bb8b6c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: ef37ccd736b4fbb007db821ac97f300ffcf8f3ba
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: b4a51c9df0262d098ab4a9b9f632739d42ecda27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: 1cbc29ff4f29d3088996a48e289df21a695c79fd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 1, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: 527bcece1fcbff48aef38a92129d35b7a3d305f4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 3, 2023
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: ef1771935276ea28d46fd7b54884471d98cf2e77
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 4, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: b4c702b4ff7866fb51c7a29bba8357c3d439f0f1
huntie added a commit to huntie/react-native that referenced this pull request Sep 9, 2023
…ebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Reviewed By: motiz88

Differential Revision: D46187942

fbshipit-source-id: b4c702b4ff7866fb51c7a29bba8357c3d439f0f1
@huntie huntie changed the title Remove Flipper actions in Dev Menu, add new Open Debugger action Remove Flipper actions in Dev Menu, add new Open Debugger action (Android) Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 14, 2023
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Differential Revision: D46187942

fbshipit-source-id: 1e66f75e06398ad2901359f2c185514c74b7baf7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 15, 2023
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Differential Revision: D46187942

fbshipit-source-id: b0a218801fea48d32cfc75dbfa10cc2cf47a9fff
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 15, 2023
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Reviewed By: cortinico

Differential Revision: D46187942

fbshipit-source-id: 27703dc89ffa773f3367ff0df336a4e43a0dca85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

huntie added a commit to huntie/react-native that referenced this pull request Sep 15, 2023
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Reviewed By: cortinico

Differential Revision: D46187942

fbshipit-source-id: b23a46e2cf34571cccdca605e76cee2be136677d
huntie and others added 3 commits September 15, 2023 06:39
Differential Revision: D49276125

fbshipit-source-id: 5ae43d865efed61a1bcb1395d1eb2512643b4e06
Differential Revision: https://internalfb.com/D46220076

fbshipit-source-id: 2cc0050febf0ca095190a7103988f6ead92e1e7a
…roid) (facebook#39254)

Summary:
Pull Request resolved: facebook#39254

## Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

## Changes

- Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
- Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

#rn-oss-skip-export

Reviewed By: cortinico

Differential Revision: D46187942

fbshipit-source-id: 17041104eb8edf84eb90c0bed20458f51f2812fe
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46187942

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b924fe7

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 16, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3bc402f.

@huntie huntie deleted the export-D46187942 branch February 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants