-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cocoapods] min_ios_version_supported -> min_supported_versions #39310
Conversation
@Saadnajmi could you please rebase on the latest main, as there were unrelated CircleCI failures recently. |
Uuuh, I seem to have messed up the branch a bit with the rebase, I'll fix shortly |
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: ef3e771 |
Should be fixed now! |
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Saadnajmi there are some Ruby Test failures. Reproducible locally with
Could you please fix them? |
Sorry, I think this will still fail actually (seeing that locally). Give me a bit while I learn more about ruby :D |
@dmytrorykun looks like we're good now! |
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @Saadnajmi in 1b78da8. When will my fix make it into a release? | Upcoming Releases |
Summary: One of the most common diffs we have in React Native macOS is simply extending the `platforms` key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a `min_supported_versions` hash that can be overridden at one place that is extensible to more platforms, instead of just specifying `min_ios_version_supported`. Note: In doing this change, I have set it that `React-Hermes.podspec` doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back? [IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts Pull Request resolved: facebook#39310 Test Plan: CI should pass. Reviewed By: NickGerleman Differential Revision: D49014109 Pulled By: dmytrorykun fbshipit-source-id: d44fc7b750c70cc263a2c89502c022a0db9a4771
) * updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget (facebook#39570) Summary: While merging new commits into React Native macOS, I noticed facebook#39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: facebook#39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d * min_ios_version_supported -> min_supported_versions (facebook#39310) Summary: One of the most common diffs we have in React Native macOS is simply extending the `platforms` key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a `min_supported_versions` hash that can be overridden at one place that is extensible to more platforms, instead of just specifying `min_ios_version_supported`. Note: In doing this change, I have set it that `React-Hermes.podspec` doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back? [IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts Pull Request resolved: facebook#39310 Test Plan: CI should pass. Reviewed By: NickGerleman Differential Revision: D49014109 Pulled By: dmytrorykun fbshipit-source-id: d44fc7b750c70cc263a2c89502c022a0db9a4771 * Set macOS deployment target
@bingDBdu Without knowing much of your setup, I see you're using cocoapods 1.15.0, which I think is actually not compatible with React Native at the moment. Also are you on RN 0.73? |
Summary:
One of the most common diffs we have in React Native macOS is simply extending the
platforms
key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define amin_supported_versions
hash that can be overridden at one place that is extensible to more platforms, instead of just specifyingmin_ios_version_supported
.Note: In doing this change, I have set it that
React-Hermes.podspec
doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back?Changelog:
[IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts
Test Plan:
CI should pass.