Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Remove RCTGetMultiplierForContentSizeCategory #39617

Closed
wants to merge 2 commits into from
Closed

[iOS] Remove RCTGetMultiplierForContentSizeCategory #39617

wants to merge 2 commits into from

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Sep 23, 2023 •
edited by cipolleschi
Loading

Summary:

It seems this method is not referenced by anything anymore. I think #35017 made it redundant. Let's remove it?
I can also do the whole "Deprecate for one version, remove in the next" since this was publicly exported.

Changelog:

[iOS] [REMOVED] - Remove RCTGetMultiplierForContentSizeCategory

Test Plan:

CI should pass

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 23, 2023
@ryancat
Copy link
Contributor

ryancat commented Sep 25, 2023

Yeah the concern would be public API being visible to unknown apps. What's the proper deprecation steps look like and how we enforce it? @cipolleschi

@cipolleschi
Copy link
Contributor

Yeah, it seems like we are not even using this internally.
So... lets do the right thing:

  • Let's add a deprecated annotation first.
  • Let's release a version with the deprecation
  • Let's remove the code in the next release

@Saadnajmi
Copy link
Contributor Author

Yeah, it seems like we are not even using this internally.

So... lets do the right thing:

  • Let's add a deprecated annotation first.

  • Let's release a version with the deprecation

  • Let's remove the code in the next release

To be clear, deprecate in 0.73 and remove in 0.74?

@facebook-github-bot
Copy link
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Saadnajmi Saadnajmi mentioned this pull request Sep 26, 2023
Closed
@Saadnajmi
Copy link
Contributor Author

Deprecation done here: #39643, I'll revisit this PR post 0.73.

facebook-github-bot pushed a commit that referenced this pull request Oct 3, 2023
@Saadnajmi @facebook-github-bot
Deprecate RCTGetMultiplierForContentSizeCategory (#39643)
f174f02 
Summary:
Per #39617 (comment) , let's deprecate this method first.
bypass-github-export-checks

## Changelog:

[IOS] [DEPRECATED] - Deprecate RCTGetMultiplierForContentSizeCategory

Pull Request resolved: #39643

Test Plan: CI should pass

Reviewed By: dmytrorykun

Differential Revision: D49637172

Pulled By: cipolleschi

fbshipit-source-id: 20dc70c737ef51efd5a5aa38832fb47b5d49e641
@Saadnajmi Saadnajmi mentioned this pull request Oct 3, 2023
Merged
@Saadnajmi
Copy link
Contributor Author

Yeah, it seems like we are not even using this internally.

So... lets do the right thing:

  • Let's add a deprecated annotation first.

  • Let's release a version with the deprecation

  • Let's remove the code in the next release

Now that #39785 merged, can we revisit this?

@cipolleschi
Copy link
Contributor

yeah... branch has been cut and the other commit is in the cherry pick list.
Could you rebase and fix the conflict, please?

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 9, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 6a2c245.

@Saadnajmi Saadnajmi deleted the fontsizemultiplier branch October 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saadnajmi @ryancat @cipolleschi @facebook-github-bot