Update 'cannot calculate shadow efficiently' log message #39700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
deleted the
@gabrieldonadel/update-calculate-shadow-efficiently-warning
branch
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
) Summary: While working in an app I kept getting these `View X of type Y has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this` warnings even though I had added a background color to that view. Upon inspecting RCTView.m I notice that what is actually required to fix this is a solid background To make this a bit clearer to developers I believe we should update this log message to explicitly say "solid background" instead of "background" ## Changelog: [IOS] [CHANGED] - Update 'cannot calculate shadow efficiently' log message to explicitly say solid background Pull Request resolved: facebook#39700 Test Plan: N / A Reviewed By: christophpurrer Differential Revision: D51584574 Pulled By: javache fbshipit-source-id: b1741f7002ebb876e4a50959bef7f39df76a5c3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working in an app I kept getting these
View X of type Y has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix thiswarnings even though I had added a background color to that view. Upon inspecting RCTView.m I notice that what is actually required to fix this is a solid backgroundTo make this a bit clearer to developers I believe we should update this log message to explicitly say "solid background" instead of "background"
Changelog:
[IOS] [CHANGED] - Update 'cannot calculate shadow efficiently' log message to explicitly say solid background
Test Plan:
N / A