Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChoreographerCompat #39775

Closed
wants to merge 1 commit into from
Closed

Remove ChoreographerCompat #39775

wants to merge 1 commit into from

Conversation

javache
Copy link
Member

@javache javache commented Oct 3, 2023

Summary:
ChoreographerCompat existed to support JellyBean, but given we target Android SDK 23+ now, this is safe to remove.

Changelog: [Android][Removed] Deprecated ChoreographerCompat.FrameCallback, use Choreographer.FrameCallback

Reviewed By: mdvacca

Differential Revision: D49826889

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 3, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49826889

@analysis-bot
Copy link

analysis-bot commented Oct 3, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,820 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,589 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c7c7831
Branch: main

@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b15ea69

@javache @facebook-github-bot
Remove ChoreographerCompat (facebook#39775)
b15ea69 
Summary:

ChoreographerCompat existed to support JellyBean, but given we target Android SDK 23+ now, this is safe to remove.

Changelog: [Android][Removed] Deprecated ChoreographerCompat.FrameCallback, use Choreographer.FrameCallback

Reviewed By: mdvacca

Differential Revision: D49826889
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49826889

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 3, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 248c324.

@javache javache deleted the export-D49826889 branch October 3, 2023 20:40
@marco-saia-datadog marco-saia-datadog mentioned this pull request Jul 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javache @facebook-github-bot @analysis-bot