Reuse Yoga enum ToString functions #41021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
Base commit: 2bf1a8f |
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Differential Revision: D50347728 fbshipit-source-id: 7f6317eed6e0b1919d15374ae700c78b0c0175dd
NickGerleman
force-pushed
the
export-D50347728
branch
from
0053936
to
49cd61d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Differential Revision: D50347728 fbshipit-source-id: 48112be6639d57bcb2a034f31c8fcb8ac4720ef5
NickGerleman
force-pushed
the
export-D50347728
branch
from
49cd61d
to
dbf8e3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: 21ade343d394116f5e3885c03f0f186aa4ba6296
NickGerleman
force-pushed
the
export-D50347728
branch
from
dbf8e3b
to
a4074e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: da552af70bfb6c68dcd9fd3044f5af1773630bb5
NickGerleman
force-pushed
the
export-D50347728
branch
from
a4074e6
to
6a2f4f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: a434d431b9bb4920f9b05422cd87ea539b1e5c03
NickGerleman
force-pushed
the
export-D50347728
branch
from
6a2f4f4
to
3fddb8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: 93d28cccf310b590efc1b796c6a92bf0ab10bebb
NickGerleman
force-pushed
the
export-D50347728
branch
from
3fddb8e
to
cdb02c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: bb9c92fb250c8af28e86d3651359f7a0d77ab565
NickGerleman
force-pushed
the
export-D50347728
branch
from
cdb02c9
to
f395c01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: 30c94a904e371ac9b3f8fd9879459b1efefb98f7
NickGerleman
force-pushed
the
export-D50347728
branch
from
f395c01
to
d61eeeb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: e16675e41a93b18e6f5ff2543162886df3012b42
NickGerleman
force-pushed
the
export-D50347728
branch
from
d61eeeb
to
68b1e9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: 3a1a860c680cac2ac1a54fce32f7725cf8fad666
NickGerleman
force-pushed
the
export-D50347728
branch
from
68b1e9b
to
d4fc6bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: c914b42662de9583a096ad9cee2f6abdfe36381b
NickGerleman
force-pushed
the
export-D50347728
branch
from
d4fc6bd
to
917c20e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
force-pushed
the
export-D50347728
branch
from
917c20e
to
252273f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 17, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: b53c2631f0cd9339356a388a1a89ee8f02ea3eac
NickGerleman
force-pushed
the
export-D50347728
branch
from
252273f
to
212eb99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
Summary: ### Changes made - Regenerated tests (as some aspect ratio tests seem to be out of date compared to the fixtures) - Added SpaceEvenly variant to the "Align" enums (via enums.py) - Implemented `align-content: space-evenly` alignment in CalculateLayout.cpp - Added generated tests `align-content: space-evenly` - Updated NumericBitfield test to account for the fact that the Align enum now requires more bits (this bit could do with being reviewed as I am not 100% certain that it's valid to just update the test like this). ### Changes not made - Any attempt to improve the spec-compliance of content alignment in general (e.g. I think facebook/yoga#1013 probably still needs to happen) X-link: facebook/yoga#1422 Reviewed By: yungsters Differential Revision: D50305438 Pulled By: NickGerleman
Summary: Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728
|
This pull request was exported from Phabricator. Differential Revision: D50347728 |
NickGerleman
force-pushed
the
export-D50347728
branch
from
212eb99
to
b37ec4e
Compare
|
This pull request has been merged in 9a03e99. |
|
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41021 Yoga has generated public `ToString` functions for enums already. Don't duplicate in Fabric. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D50347728 fbshipit-source-id: 353106091eb5a5ab6e98a816da876bb4ccadbd29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Yoga has generated public
ToStringfunctions for enums already. Don't duplicate in Fabric.Changelog: [Internal]
Differential Revision: D50347728