Simplify getting padding + border for cross axis in algorithm #41208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 26, 2023
Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177 fbshipit-source-id: aca6b0c457ee0b55eee233919335ed04c51dd9a0
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 26, 2023
…ok#1437) Summary: Pull Request resolved: facebook#1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177 fbshipit-source-id: 563780b0a10d2f5851e155fb6d8f8b50073c6ac6
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 27, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 27, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
3b1ad41
to
80369f4
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 27, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 27, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: D50704177
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
Base commit: d11d5f3 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 2, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 2, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 2, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 2, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
80369f4
to
b669349
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 2, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 2, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
b669349
to
ac350ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 3, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 3, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
ac350ac
to
cbf1985
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
6cd71a2
to
6cbbdfc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
6cbbdfc
to
1d03a12
Compare
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: Pull Request resolved: facebook#1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: db259b75b19876b9d53e9499cbb81532d3744a03
NickGerleman
pushed a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Pull Request resolved: facebook#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: db259b75b19876b9d53e9499cbb81532d3744a03
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: Pull Request resolved: facebook#1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: a52075273676955889ddd80494ac34b1094ef04e
NickGerleman
pushed a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Pull Request resolved: facebook#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: fabc45f55b24a01641f2a1eac3a2028d0aa2f8db
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
1d03a12
to
117a7b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
NickGerleman
pushed a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
…ok#41208) Summary: X-link: facebook/yoga#1437 Pull Request resolved: facebook#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: 6abd5d69a84995522587b09152a48d23e8663fd6
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: Pull Request resolved: facebook#1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Differential Revision: https://www.internalfb.com/diff/D50704177?entry_point=27 fbshipit-source-id: 5b843c783e007a6996fe7a6bece21d0f27718038
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
…ok#1437) Summary: X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
joevilches
force-pushed
the
export-D50704177
branch
from
117a7b2
to
2da8fd4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50704177 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177 fbshipit-source-id: 1a091edbfee6482a2bf472aca2980702bd75ad94
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 7, 2023
Summary: Pull Request resolved: #1437 X-link: facebook/react-native#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177 fbshipit-source-id: 1a091edbfee6482a2bf472aca2980702bd75ad94
|
This pull request was successfully merged by @joevilches in 1984bcc. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ok#41208) Summary: X-link: facebook/yoga#1437 Pull Request resolved: facebook#41208 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177 fbshipit-source-id: 1a091edbfee6482a2bf472aca2980702bd75ad94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner
Differential Revision: D50704177