Making setFabricEnabled Flag optional for ReactFragments #41211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ricku44
changed the title
facebook-github-bot
added
the
Shared with Meta
Base commit: ac7b158 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Oct 27, 2023
|
This pull request was successfully merged by @ricku44 in a337f6e. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
) Summary: Making setFabricEnabled Flag optional for ReactFragments ## Changelog: [ANDROID][CHANGED] - Continuation of PR: 36263 Pull Request resolved: facebook#41211 Test Plan: Kotlin Code Snippet to test: ``` supportFragmentManager .beginTransaction() .add(android.R.id.content, ReactFragment.Builder() .setComponentName("componentName") .setFabricEnabled(true) .build()) .commit() ``` Reviewed By: cipolleschi Differential Revision: D50732345 Pulled By: cortinico fbshipit-source-id: 812fe1abeb8c09334bd755ce3a29f55ce8b7ac7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Making setFabricEnabled Flag optional for ReactFragments
Changelog:
[ANDROID][CHANGED] - Continuation of PR: 36263
Test Plan:
Kotlin Code Snippet to test: