Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI] Configure E2E tests to run on a commit that contains #run-e2e-tests #41308

Closed
wants to merge 3 commits into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

This change allow our CI to run E2E tests using a specific tag in the commit message

Changelog:

[Internal] - Allow to run e2e test using a specific tag in the last commit message

Test Plan:

CircleCI is green
Tested interacting with the PR/branch

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 3, 2023
@cipolleschi cipolleschi marked this pull request as ready for review November 3, 2023 16:00
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Nov 3, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,641,848 -8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,021,602 -14
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5a7ae61
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/e2e-enable-on-commit branch from 8ff4cf8 to 8f146c4 Compare November 8, 2023 09:12
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

github-actions bot commented Nov 8, 2023

This pull request was successfully merged by @cipolleschi in bb4e940.

When will my fix make it into a release? | Upcoming Releases

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 8, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in bb4e940.

facebook-github-bot pushed a commit that referenced this pull request Nov 9, 2023
Summary:
#41308 introduce the possibility to run e2e tests if a commit contains #run-e2e-tests in the commit message.
This PR builds on top of that, and let users to run e2e tests by adding a comment with with #run-e2e-tests

## Changelog:
[Internal] - Allow to run e2e tests from comments

Pull Request resolved: #41311

Test Plan: Not sure it can be tested until the PR is merged... ¯\_(ツ)_/¯

Reviewed By: dmytrorykun

Differential Revision: D51111543

Pulled By: cipolleschi

fbshipit-source-id: e6c55950552f03830fa35c89d385ab9b17f8facb
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…acebook#41308)

Summary:
This change allow our CI to run E2E tests using a specific tag in the commit message

[Internal] - Allow to run e2e test using a specific tag in the last commit message

Pull Request resolved: facebook#41308

Test Plan:
CircleCI is green
Tested interacting with the PR/branch

Reviewed By: NickGerleman

Differential Revision: D50975588

Pulled By: cipolleschi

fbshipit-source-id: 6318800d7e86e1cab394af2b320e280304189dd2
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
facebook#41308 introduce the possibility to run e2e tests if a commit contains #run-e2e-tests in the commit message.
This PR builds on top of that, and let users to run e2e tests by adding a comment with with #run-e2e-tests

## Changelog:
[Internal] - Allow to run e2e tests from comments

Pull Request resolved: facebook#41311

Test Plan: Not sure it can be tested until the PR is merged... ¯\_(ツ)_/¯

Reviewed By: dmytrorykun

Differential Revision: D51111543

Pulled By: cipolleschi

fbshipit-source-id: e6c55950552f03830fa35c89d385ab9b17f8facb
@cortinico cortinico deleted the cipolleschi/e2e-enable-on-commit branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants