Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make position static behave like position static #41685

Closed
wants to merge 2 commits into from
Closed

Make position static behave like position static #41685

wants to merge 2 commits into from

Conversation

joevilches
Copy link
Contributor

Summary: This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to calculateLayoutInternal that is in layoutAbsoluteChild

Reviewed By: NickGerleman

Differential Revision: D51293606

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51293606

joevilches added a commit to joevilches/react-native that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
efbc3a7 
Summary:

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
539cd92 
Summary:

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
d778000 
Summary:

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
85370f5 
Summary:

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
2cc0052 
Summary:

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Nov 29, 2023
@joevilches @facebook-github-bot
Make position static behave like position static
d14487b 
Summary:
X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: 9e88116761406f9300c9bd260cd7662b9b25ab5f
@joevilches joevilches mentioned this pull request Nov 29, 2023
Closed
@analysis-bot
Copy link

analysis-bot commented Nov 29, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,514,812 +1,152
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,889,495 +5,246
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8081265
Branch: main

joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
1fbc824 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
b26da93 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
489ec73 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
a93da61 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51293606

joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
85c44f6 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
fac2b65 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
975a0c1 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: b90de742dae3c635ff8e30702073c87f0bd2e9a9
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 4, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
442484f 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 5, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
373a38b 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 5, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
b7aec59 
Summary:

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51293606

joevilches added a commit to joevilches/yoga that referenced this pull request Dec 5, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
6782204 
Summary:

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 5, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
3bd67de 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 5, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
78ed60e 
Summary:

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
13159ba 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
377ed50 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: 21c7ae7edec1a08b09c7c948d4ef1ee412df23ab
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
edbb2a8 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: 1634e5963603360b351da9531f3bbe7bd814cf9b
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
dcea4f1 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: 4684055f44344f1608e615968b19e82dde7f39de
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
8518762 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: ff285316796d1db811d4dcfaf100c1cb73d4c463
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
92cf8aa 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: aad97dc8ee797582b73544857fd398acaf488b11
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
5f072da 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: bea02c6dd891e6be421c07de038755d455c54eff
Joe Vilches and others added 2 commits December 7, 2023 14:39
@facebook-github-bot
Make positionAbsoluteChild the sole place that matters when determini…
6d812b2 
…ng absolute node's position (facebook#41684)

Summary:
X-link: facebook/yoga#1481


Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent.

With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51290723
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
f8c4a6a 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
340a792 
Summary:

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
0dd5efb 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
207aae1 
Summary:

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
8db640e 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51293606

joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
6194a8b 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
e94baa6 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
6201940 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/react-native that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#41685)
1a05e80 
Summary:
X-link: facebook/yoga#1482


This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
3d6cb74 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: e09fe3951b5a70668ab700c1a11f872a143ea5dd
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
c424d8b 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: cb3174fe68a652732323881f619fb4e91ae7eb4e
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
0e1e5cf 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: 6837a5e6057f0bbce401f91c23989f5bc602800d
joevilches added a commit to joevilches/yoga that referenced this pull request Dec 7, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (facebook#1482)
2349a2a 
Summary:
Pull Request resolved: facebook#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27

fbshipit-source-id: e4b0b46c984210c0c4b066046917aa67c63e7bce
facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Dec 8, 2023
@joevilches @facebook-github-bot
Make position static behave like position static
4a8984a 
Summary:
X-link: facebook/yoga#1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 475036d.

facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Dec 8, 2023
@joevilches @facebook-github-bot
Make position static behave like position static (#1482)
f6c4a8e 
Summary:
Pull Request resolved: #1482

X-link: facebook/react-native#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@joevilches @Othinn
Make position static behave like position static (facebook#41685)
157b857 
Summary:
X-link: facebook/yoga#1482

Pull Request resolved: facebook#41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joevilches @facebook-github-bot @analysis-bot