Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert NetworkingModuleTest to kotlin #41792

Closed
wants to merge 2 commits into from
Closed

refactor: convert NetworkingModuleTest to kotlin #41792

wants to merge 2 commits into from

Conversation

KrzysztofMoch
Copy link
Contributor

@KrzysztofMoch KrzysztofMoch commented Dec 4, 2023 •
edited
Loading

Summary:

Migrated NetworkingModuleTest to kotlin (part of #38825)

Changelog:

[Android] [CHANGED] - NetworkingModuleTest.java -> NetworkingModuleTest.kt

Test Plan:

./gradlew :packages:react-native:ReactAndroid:test

@facebook-github-bot
Copy link
Contributor

Hi @KrzysztofMoch!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,726,022 -72
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,113,185 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a481ae7
Branch: main

@KrzysztofMoch
Copy link
Contributor Author

I was unable to fix last 3 tests - testCancelSomeCallsInvalidate, testCancelAllCallsInvalidate, testMultipartPostRequestBody

@cortinico, @mdvacca I would greatly appreciate the reviews from you

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 4, 2023
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

rshest
rshest reviewed Dec 5, 2023
View reviewed changes
...native/ReactAndroid/src/test/java/com/facebook/react/modules/network/NetworkingModuleTest.kt
}

@Test
@Ignore("TODO: Fix me")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this get test clause get broken during conversion?

@rshest
Copy link
Contributor

rshest commented Dec 5, 2023 •
edited
Loading

@KrzysztofMoch Thanks for working on this one!

I see there are three test clauses that got disabled in the conversion process, however - those must be fixed before this can be merged.

@rshest
Copy link
Contributor

rshest commented Dec 5, 2023 •
edited
Loading

@KrzysztofMoch Thanks for working on this one!

I see there are three test clauses that got disabled in the conversion process, however - those must be fixed before this can be merged.

Ah, I've just realized that the whole suite was ignored before conversion and none of the tests were executed.

Those tests would fail before the conversion as well, so it's not your change's fault.

@KrzysztofMoch
Copy link
Contributor Author

Yeah, I tried to fix them but wasn't able to. Can we left it as it is, or should I do something with it ?

@rshest
Copy link
Contributor

rshest commented Dec 5, 2023

Yeah, I tried to fix them but wasn't able to. Can we left it as it is, or should I do something with it ?

No, it's alright, let's leave them like that for now, it's better be done as a follow up.

You've effectively enabled a bunch of tests running, not disabled, so kudos :)

@KrzysztofMoch
Copy link
Contributor Author

Cool 🙌, let me know if you will need something

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 5, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in 852f2b1.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@KrzysztofMoch @Othinn
refactor: convert NetworkingModuleTest to kotlin (facebook#41792)
d905d33 
Summary:
Migrated `NetworkingModuleTest` to kotlin (part of facebook#38825)

## Changelog:
[Android] [CHANGED] - NetworkingModuleTest.java -> NetworkingModuleTest.kt

Pull Request resolved: facebook#41792

Test Plan: `./gradlew :packages:react-native:ReactAndroid:test`

Reviewed By: cortinico

Differential Revision: D51847402

Pulled By: rshest

fbshipit-source-id: 7a1938c575a7e5b22b6ff578e1f8d26b600f2c27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshest rshest rshest left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KrzysztofMoch @facebook-github-bot @analysis-bot @rshest