deprecate @property methodQueue #41944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52150696 |
philIip
force-pushed
the
export-D52150696
branch
from
1982ae7
to
00f3cdd
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Dec 14, 2023
Summary: Changelog: [iOS][Deprecated] i think we can now communicate the deprecation of this selector. after removing all of the synthesize methodQueue callsites in our codebase, our native modules are still stable, save for one native module, RCTNetworking. so i feel comfortable recommending users to create their own queues. and after removing `methodQueue` overrides to support synchronous void methods, those modules are also still stable, so i'm also comfortable we can recommend handling the dispatch_async in the product layer. Reviewed By: arushikesarwani94, cipolleschi Differential Revision: D52150696
|
This pull request was exported from Phabricator. Differential Revision: D52150696 |
Summary: Changelog: [iOS][Deprecated] i think we can now communicate the deprecation of this selector. after removing all of the synthesize methodQueue callsites in our codebase, our native modules are still stable, save for one native module, RCTNetworking. so i feel comfortable recommending users to create their own queues. and after removing `methodQueue` overrides to support synchronous void methods, those modules are also still stable, so i'm also comfortable we can recommend handling the dispatch_async in the product layer. Reviewed By: arushikesarwani94, cipolleschi Differential Revision: D52150696
philIip
force-pushed
the
export-D52150696
branch
from
00f3cdd
to
1a63243
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52150696 |
|
This pull request was successfully merged by @philIip in a0efa26. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in a0efa26. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41944 Changelog: [iOS][Deprecated] i think we can now communicate the deprecation of this selector. after removing all of the synthesize methodQueue callsites in our codebase, our native modules are still stable, save for one native module, RCTNetworking. so i feel comfortable recommending users to create their own queues. and after removing `methodQueue` overrides to support synchronous void methods, those modules are also still stable, so i'm also comfortable we can recommend handling the dispatch_async in the product layer. Reviewed By: arushikesarwani94, cipolleschi Differential Revision: D52150696 fbshipit-source-id: ff6b90fc685796e5560167f1377a76526ee07744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Deprecated]
i think we can now communicate the deprecation of this selector.
after removing all of the synthesize methodQueue callsites in our codebase, our native modules are still stable, save for one native module, RCTNetworking. so i feel comfortable recommending users to create their own queues.
and after removing
methodQueueoverrides to support synchronous void methods, those modules are also still stable, so i'm also comfortable we can recommend handling the dispatch_async in the product layer.Reviewed By: arushikesarwani94, cipolleschi
Differential Revision: D52150696