Add test asserting shape of public JS API #42265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
huntie
force-pushed
the
export-D52729777
branch
from
e3a4654
to
d1230f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 12, 2024
Summary: Adds a snapshot test against the `react-native` package which emits the shape of all Flow-typed modules under `Libraries/`, as an approximation of the public JS API. This provides: - Visibility for maintainers on any PR which changes the shape of the public API. - An at-a-glance diff of changed APIs between React Native versions (useful for library integrators and the Release Crew). Note — **workflow change**: Maintainers modifying public files/function signatures under Libraries/ will need to run `yarn jest -u` and commit the updated snapshot changes. Changelog: [Internal] Reviewed By: TheSavior, philIip, mdvacca Differential Revision: D52729777
huntie
force-pushed
the
export-D52729777
branch
from
d1230f1
to
4906f88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
Base commit: e859f6c |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 12, 2024
Summary: Adds a snapshot test against the `react-native` package which emits the shape of all Flow-typed modules under `Libraries/`, as an approximation of the public JS API. This provides: - Visibility for maintainers on any PR which changes the shape of the public API. - An at-a-glance diff of changed APIs between React Native versions (useful for library integrators and the Release Crew). Note — **workflow change**: Maintainers modifying public files/function signatures under Libraries/ will need to run `yarn jest -u` and commit the updated snapshot changes. Changelog: [Internal] Reviewed By: TheSavior, philIip, mdvacca Differential Revision: D52729777
huntie
force-pushed
the
export-D52729777
branch
from
4906f88
to
1dd0112
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
Summary: Adds a snapshot test against the `react-native` package which emits the shape of all Flow-typed modules under `Libraries/`, as an approximation of the public JS API. This provides: - Visibility for maintainers on any PR which changes the shape of the public API. - An at-a-glance diff of changed APIs between React Native versions (useful for library integrators and the Release Crew). Note — **workflow change**: Maintainers modifying public files/function signatures under Libraries/ will need to run `yarn jest -u` and commit the updated snapshot changes. Changelog: [Internal] Reviewed By: TheSavior, philIip, mdvacca Differential Revision: D52729777
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 14, 2024
Summary: Adds a snapshot test against the `react-native` package which emits the shape of all Flow-typed modules under `Libraries/`, as an approximation of the public JS API. This provides: - Visibility for maintainers on any PR which changes the shape of the public API. - An at-a-glance diff of changed APIs between React Native versions (useful for library integrators and the Release Crew). Note — **workflow change**: Maintainers modifying public files/function signatures under Libraries/ will need to run `yarn jest -u` and commit the updated snapshot changes. Changelog: [Internal] Reviewed By: TheSavior, philIip, mdvacca Differential Revision: D52729777
huntie
force-pushed
the
export-D52729777
branch
from
1dd0112
to
ed922eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
huntie
force-pushed
the
export-D52729777
branch
from
ed922eb
to
7955351
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52729777 |
|
This pull request has been merged in 9eb5833. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a snapshot test against the
react-nativepackage which emits the shape of all Flow-typed modules underLibraries/, as an approximation of the public JS API.This provides:
Note — workflow change: Maintainers modifying public files/function signatures under Libraries/ will need to run
yarn jest -uand commit the updated snapshot changes.Changelog: [Internal]
Differential Revision: D52729777