Fix missing assignment in Node move constructor #42275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
Base commit: 2c4756c |
NickGerleman
force-pushed
the
export-D52767525
branch
from
5b35fdc
to
7c6aae0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/react-native#42275 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 16, 2024
Summary: X-link: facebook/yoga#1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
force-pushed
the
export-D52767525
branch
from
7c6aae0
to
f0109a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42275 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
force-pushed
the
export-D52767525
branch
from
f0109a1
to
611b2f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42275 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
force-pushed
the
export-D52767525
branch
from
611b2f8
to
2b86661
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
Summary: X-link: facebook/yoga#1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42275 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525
NickGerleman
force-pushed
the
export-D52767525
branch
from
2b86661
to
d6decad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52767525 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42275 Pull Request resolved: #1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525 fbshipit-source-id: ec68452b058178967650bbef736562caafbf4a36
|
This pull request has been merged in 90df90e. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/react-native#42275 X-link: facebook/yoga#1554 Adds recently added field missing from move constructor Reviewed By: joevilches Differential Revision: D52767525 fbshipit-source-id: ec68452b058178967650bbef736562caafbf4a36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds recently added field missing from move constructor
Differential Revision: D52767525