RNTester - Legacy component example: do not convert commands to string #42822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53123956 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 2, 2024
facebook#42822) Summary: The conversion to string was introduced in D45043929. It was supposed to fix command execution for `MyLegacyNativeComponent` in RNTester on Android/Old Architecture. At the same time it introduced a regression on iOS, since we have [different code path](https://www.internalfb.com/code/fbsource/[ffee789cab9514c0a15b8a63869cbfdf4e534a56]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.m?lines=1088-1092) for string commands in iOS, where we expect command name, and not command number converted to string. I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android. Looks like the underlying issue has been fixed in some other way. So let's just remove those conversions. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53123956
dmytrorykun
force-pushed
the
export-D53123956
branch
from
5134546
to
8b02feb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53123956 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 2, 2024
facebook#42822) Summary: The conversion to string was introduced in D45043929. It was supposed to fix command execution for `MyLegacyNativeComponent` in RNTester on Android/Old Architecture. At the same time it introduced a regression on iOS, since we have [different code path](https://www.internalfb.com/code/fbsource/[ffee789cab9514c0a15b8a63869cbfdf4e534a56]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.m?lines=1088-1092) for string commands in iOS, where we expect command name, and not command number converted to string. I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android. Looks like the underlying issue has been fixed in some other way. So let's just remove those conversions. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53123956
dmytrorykun
force-pushed
the
export-D53123956
branch
from
8b02feb
to
e9e0fbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53123956 |
dmytrorykun
force-pushed
the
export-D53123956
branch
from
e9e0fbc
to
a6d2c5a
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 5, 2024
facebook#42822) Summary: The conversion to string was introduced in D45043929. It was supposed to fix command execution for `MyLegacyNativeComponent` in RNTester on Android/Old Architecture. At the same time it introduced a regression on iOS, since we have [different code path](https://www.internalfb.com/code/fbsource/[ffee789cab9514c0a15b8a63869cbfdf4e534a56]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.m?lines=1088-1092) for string commands in iOS, where we expect command name, and not command number converted to string. I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android. Looks like the underlying issue has been fixed in some other way. So let's just remove those conversions. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53123956
|
This pull request was exported from Phabricator. Differential Revision: D53123956 |
facebook#42822) Summary: The conversion to string was introduced in D45043929. It was supposed to fix command execution for `MyLegacyNativeComponent` in RNTester on Android/Old Architecture. At the same time it introduced a regression on iOS, since we have [different code path](https://www.internalfb.com/code/fbsource/[ffee789cab9514c0a15b8a63869cbfdf4e534a56]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.m?lines=1088-1092) for string commands in iOS, where we expect command name, and not command number converted to string. I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android. Looks like the underlying issue has been fixed in some other way. So let's just remove those conversions. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53123956
dmytrorykun
force-pushed
the
export-D53123956
branch
from
a6d2c5a
to
c1c7fcd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53123956 |
|
This pull request has been merged in d66d651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The conversion to string was introduced in D45043929. It was supposed to fix command execution for
MyLegacyNativeComponentin RNTester on Android/Old Architecture.At the same time it introduced a regression on iOS, since we have different code path for string commands in iOS, where we expect command name, and not command number converted to string.
I tried to remove that conversion, did local tests, and saw no issues with executing commands on Android.
Looks like the underlying issue has been fixed in some other way.
So let's just remove those conversions.
Changelog: [Internal]
Differential Revision: D53123956