fix(Codegen): case where no platform
or deployment_target
is specified
#42867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a specific case pointed out by @dmytrorykun, where there might be no platform or
deployment_target
specified at all and in that case we assume that this library supports every platform (same as Cocoapods).Changelog:
[IOS] [FIXED] - Don't add compiler conditionals when no platforms are specified
Test Plan:
Test running codegen when library doesn't specify a
platform
:Check generated
RCTThirdPartyFabricComponentsProvider