disable "Open Debugger" menu item if the bundler is disconnected #42876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
555b90a
to
fd38958
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
fd38958
to
1bd092c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
1bd092c
to
242e71f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
242e71f
to
b577385
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
Base commit: db066ac |
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Feb 5, 2024
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
b577385
to
1bedcd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
…ebook#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
1bedcd1
to
fcc97b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
|
This pull request was successfully merged by @EdmondChuiHW in 7afc8b8. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected
Existing
In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected.
{F1451833462}
In this PR
The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript"
{F1451834019}
Reference
Differential Revision: D53428914