Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding EXCLUDED_ARCHS when installing Hermes on RN v0.72 #43002

Merged

Conversation

ken0nek
Copy link
Contributor

@ken0nek ken0nek commented Feb 13, 2024

Summary:

Created the same fix on RN v0.72 as the previous fix was only available on RN v0.71 #39763

No need to fix for RN v0.73.

ref

Changelog:

[IOS] [FIXED] - don't override EXCLUDED_ARCHS when installing Hermes

Test Plan:

Tests pass

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,492,736 -8,758,306
android hermes armeabi-v7a 7810635 n/a
android hermes x86 8962829 n/a
android hermes x86_64 8824079 n/a
android jsc arm64-v8a 9,151,543 -11,461,898
android jsc armeabi-v7a 8341174 n/a
android jsc x86 9204833 n/a
android jsc x86_64 9463499 n/a

Base commit: 94bfde4
Branch: main

@lunaleaps lunaleaps merged commit a4282a9 into facebook:0.72-stable Feb 16, 2024
26 of 28 checks passed
@ken0nek ken0nek deleted the ken0nek/fix-exclude-archs-v0.72 branch February 19, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants