Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI #43049

Closed
wants to merge 2 commits into from

Conversation

cortinico
Copy link
Contributor

Summary:
This connects the OnLoad.cpp file used by OSS apps with the rncli_cxxModuleProvider.
This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.

Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI

Differential Revision: D53812109

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53812109

@analysis-bot
Copy link

analysis-bot commented Feb 15, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,885,750 +5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,240,097 +11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3a1e769
Branch: main

cortinico added a commit to cortinico/react-native that referenced this pull request Feb 19, 2024
… from RNCLI (facebook#43049)

Summary:

This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`.
This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.

This PR is currently waiting on react-native-community/cli#2296

Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI

Reviewed By: cipolleschi

Differential Revision: D53812109
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53812109

Copy link
Contributor

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53812109

cortinico added a commit to cortinico/react-native that referenced this pull request Feb 19, 2024
… from RNCLI (facebook#43049)

Summary:
Pull Request resolved: facebook#43049

This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`.
This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.

This PR is currently waiting on react-native-community/cli#2296

Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI

Reviewed By: cipolleschi

Differential Revision: D53812109
szymonrybczak and others added 2 commits February 19, 2024 07:44
Summary:
Bump CLI version to 13.6.0

## Changelog:

[GENERAL] [CHANGED] - Bump CLI to 13.6.0

Pull Request resolved: facebook#43093

Test Plan: CI

Differential Revision: D53920559

Pulled By: cortinico
… from RNCLI (facebook#43049)

Summary:
Pull Request resolved: facebook#43049

This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`.
This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.

This PR is currently waiting on react-native-community/cli#2296

Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI

Reviewed By: cipolleschi

Differential Revision: D53812109
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53812109

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4ecf57e.

huntie pushed a commit that referenced this pull request Feb 22, 2024
… from RNCLI (#43049)

Summary:
Pull Request resolved: #43049

This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`.
This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.

This PR is currently waiting on react-native-community/cli#2296

Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI

Reviewed By: cipolleschi

Differential Revision: D53812109

fbshipit-source-id: 47bc0ea699516993070cfa0127de97853acf8890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants