Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Mar 6, 2024

Summary

Following #43335, we implemented the fix suggested here.

The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper 0.248.0, and the latest flipper version on Cocoapods is 0.233.0 (15 versions behind).

Plus, we have to port the fix to 0.73 and 0.72 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.

Changelog

[iOS][Fixed] - Make 0.71 build with Xcode 15.3

Test Plan

Tested locally + CircleCI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.71-stable March 6, 2024 14:09
@cipolleschi cipolleschi marked this pull request as ready for review March 6, 2024 14:09
Copy link

github-actions bot commented Mar 6, 2024

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Generated by 🚫 dangerJS against a01ed6e

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-flipper-0.71 branch 3 times, most recently from 6f01766 to caa42d1 Compare March 6, 2024 19:22
@cipolleschi
Copy link
Contributor Author

I also bumped the podfile.lock

@fellipe-ribeiro
Copy link

@cipolleschi Do you have any estimated deadline for merging this PR?

@mjvestal
Copy link

Can we get movement on this? 0.71 is within the support window but people using XCode 15.3 cannot build without this fix.

@young-st511
Copy link

Hi! Could you please take a look at this PR to get it merged quickly? I am an RN 0.71 user and I really need XCode 15.4 🥲 I'm always grateful for the contributions.

@hurali97 hurali97 merged commit 87b14b4 into 0.71-stable Apr 2, 2024
49 of 51 checks passed
@cortinico cortinico deleted the cipolleschi/fix-flipper-0.71 branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants