Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onKeyDown in Bridgeless #43466

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Implement onKeyDown in Bridgeless by adding it to ReactHostImpl

Changelog:
[Android][Breaking] Implement onKeyDown in Bridgeless

Differential Revision: D54870966

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54870966

Summary:

Adding the ReactHost null check in the APIs added for ReactDelegate lately.

Changelog:
[Internal] internal

Differential Revision: D54864907
Summary:

Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl

Changelog:
[Android][Breaking] Implement `onKeyDown` in Bridgeless

Differential Revision: D54870966
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54870966

arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Mar 14, 2024
Summary:

Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl

Changelog:
[Android][Breaking] Implement `onKeyDown` in Bridgeless

Differential Revision: D54870966
arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Mar 14, 2024
Summary:

Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl

Changelog:
[Android][Breaking] Implement `onKeyDown` in Bridgeless

Differential Revision: D54870966
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b14f7d5.

cortinico pushed a commit that referenced this pull request Mar 25, 2024
Summary:
Pull Request resolved: #43466

Implement `onKeyDown` in Bridgeless by adding it to ReactHostImpl

Changelog:
[Android][Breaking] Implement `onKeyDown` in Bridgeless

Reviewed By: cortinico

Differential Revision: D54870966

fbshipit-source-id: 0f8e48b29679f1bca92f6ac7b6ebf1592cdc5dac
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants