Fix prefab header paths for rrc_text and rrc_textinput
#43591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
requested changes
Mar 21, 2024
| Pair( | ||
| "../ReactCommon/react/renderer/components/textinput/", | ||
| "react/renderer/components/androidtextinput/")), | ||
| Pair("../ReactCommon/react/renderer/components/textinput/androidtextinput", "")), |
There was a problem hiding this comment.
This folder doesn't exists and is making the whole build fail.
There was a problem hiding this comment.
Sorry, the paths got changed between 0.73 and 0.74. Should be fine now.
Base commit: 1c52d38 |
cortinico
approved these changes
Mar 21, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 623bbe6. |
huntie
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: - `rrc_textinput` at the moment points to a wrong subdirectory and needlessly adds a prefix path - `rrc_text` is missing headers for `attributedstring` which it depends on ## Changelog: [ANDROID] [FIXED] - Fixed prefab header paths for `rrc_text` and `rrc_textinput` Pull Request resolved: #43591 Reviewed By: fkgozali Differential Revision: D55199580 Pulled By: cortinico fbshipit-source-id: 85126c00943f82e908a52e05587661597761852e
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
rrc_textinputat the moment points to a wrong subdirectory and needlessly adds a prefix pathrrc_textis missing headers forattributedstringwhich it depends onChangelog:
[ANDROID] [FIXED] - Fixed prefab header paths for
rrc_textandrrc_textinputTest Plan: