Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reactnative.a -> react_cxxreact.a #43859

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
This frees up the reactnative CMake target so we could use it as single .so
for the CMake build.

Changelog:
[Internal] [Changed] - Rename reactnative.a -> react_cxxreact.a

Differential Revision: D55745640

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55745640

Summary:

This frees up the `reactnative` CMake target so we could use it as single .so
for the CMake build.

Changelog:
[Internal] [Changed] - Rename reactnative.a -> react_cxxreact.a

Differential Revision: D55745640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55745640

cortinico added a commit to cortinico/react-native that referenced this pull request Apr 5, 2024
Summary:

This frees up the `reactnative` CMake target so we could use it as single .so
for the CMake build.

Changelog:
[Internal] [Changed] - Rename reactnative.a -> react_cxxreact.a

Differential Revision: D55745640
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,918,800 +11
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,283,301 +9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 627bff2
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 03c75c2.

Copy link

github-actions bot commented Apr 5, 2024

This pull request was successfully merged by @cortinico in 03c75c2.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants