[iOS] Change bridgeless check in dev menu #43976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Apr 12, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 776f900. |
|
This pull request was successfully merged by @zhongwuzw in 776f900. When will my fix make it into a release? | How to file a pick request? |
huntie
pushed a commit
that referenced
this pull request
Apr 15, 2024
Summary: We would set the value of _bridge ivar to bridgeProxy for turbo module in bridgeless mode in #43757 , so we need to change the way of bridgeless/bridge check. ## Changelog: [IOS] [FIXED] - Change bridgeless check in dev menu Pull Request resolved: #43976 Test Plan: Dev menu shows bridgeless/bridge mode correctly. Reviewed By: christophpurrer Differential Revision: D56056640 Pulled By: cipolleschi fbshipit-source-id: 1358c3027c1d5f12c70dd4486cc1d5975c7a185a
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We would set the value of _bridge ivar to bridgeProxy for turbo module in bridgeless mode in #43757 , so we need to change the way of bridgeless/bridge check.
Changelog:
[IOS] [FIXED] - Change bridgeless check in dev menu
Test Plan:
Dev menu shows bridgeless/bridge mode correctly.