-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CircleCI Android GTest Build #44562
Conversation
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal} Differential Revision: D57299969
a9e6bff
to
bdd2646
Compare
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Differential Revision: D57299969
bdd2646
to
a2e6e88
Compare
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Reviewed By: joevilches, realsoelynn Differential Revision: D57299969
a2e6e88
to
6433393
Compare
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Reviewed By: joevilches, realsoelynn Differential Revision: D57299969
6433393
to
c9a0b90
Compare
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Base commit: 082e29e |
This pull request has been merged in 5a100ae. |
This pull request was successfully merged by @NickGerleman in 5a100ae. When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: facebook#44562 D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Reviewed By: joevilches, realsoelynn Differential Revision: D57299969 fbshipit-source-id: 1bf0b718ca5fcee03272dd0142f80ea2f8257902
Summary:
D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well.
Changelog: [Internal}
Differential Revision: D57299969