Handle lowercase->uppercase of hermes ios artifacts #44836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Sometimes, GHA creates artifacts with lowercase Debug/Release. Make sure that if it happen, we uppercase them. ## Changelog [Internal] - Handle lowercase->uppercase of hermes ios artifacts Differential Revision: D58290049
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58290049 |
|
This pull request has been merged in 2b343ca. |
|
This pull request was successfully merged by @cipolleschi in 2b343ca. When will my fix make it into a release? | How to file a pick request? |
Base commit: 538dd17 |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44836 Sometimes, GHA creates artifacts with lowercase Debug/Release. Make sure that if it happen, we uppercase them. ## Changelog [Internal] - Handle lowercase->uppercase of hermes ios artifacts Reviewed By: cortinico Differential Revision: D58290049 fbshipit-source-id: c1e76e9e5718500378ba08d26d5c4dd0620c78c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sometimes, GHA creates artifacts with lowercase Debug/Release. Make sure that if it happen, we uppercase them.
Changelog
[Internal] - Handle lowercase->uppercase of hermes ios artifacts
Differential Revision: D58290049