Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce FuseboxTracer for DevTools tracing #44840

Closed
wants to merge 1 commit into from

Conversation

bgirard
Copy link

@bgirard bgirard commented Jun 7, 2024

Summary:
Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 7, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 10, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 10, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 13, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Reviewed By: motiz88

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 13, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Reviewed By: motiz88

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 14, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 14, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 15, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 15, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 17, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 17, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
hoxyq pushed a commit to hoxyq/react-native that referenced this pull request Jun 17, 2024
Summary:
Pull Request resolved: facebook#44840

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

bgirard pushed a commit to bgirard/react-native that referenced this pull request Jun 17, 2024
Summary:
Pull Request resolved: facebook#44840

Changelog: [Internal]

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Reviewed By: motiz88

Differential Revision: D57981944
@analysis-bot
Copy link

analysis-bot commented Jun 17, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,476,604 +16,361
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,675,270 +16,363
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d8739e1
Branch: main

Summary:
Pull Request resolved: facebook#44840

Changelog: [Internal]

Introduce a simplified and minimal tracing backend for Fusebox. This backend is sufficient to implement a pretty usable performance panel.

Although the more I see how easy this is and how annoying working with Perfetto is, the more I think we should just maintain this going forward. Anyways we can figure that out incrementally. For now the plan is still for this to be temporary.

Reviewed By: motiz88

Differential Revision: D57981944
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57981944

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 30087a6.

Copy link

This pull request was successfully merged by Benoit Girard in 30087a6.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants