-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra log for case where availableHeight is undefined and sizing mode != max content #45965
Conversation
This pull request was exported from Phabricator. Differential Revision: D61054392 |
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Differential Revision: D61054392
This pull request was exported from Phabricator. Differential Revision: D61054392 |
e13e63a
to
185f5d2
Compare
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Differential Revision: D61054392
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
This pull request was exported from Phabricator. Differential Revision: D61054392 |
185f5d2
to
ec50156
Compare
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
This pull request was exported from Phabricator. Differential Revision: D61054392 |
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
ec50156
to
5fd2e1c
Compare
… != max content (#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: #1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392 fbshipit-source-id: 654ff96f94aa89605a603e2e36335bb48b61f4a2
… != max content Summary: X-link: facebook/react-native#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392 fbshipit-source-id: 654ff96f94aa89605a603e2e36335bb48b61f4a2
This pull request has been merged in 7027eac. |
This pull request was successfully merged by @joevilches in 7027eac When will my fix make it into a release? | How to file a pick request? |
Summary:
We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction.
Changelog: [Internal]
Differential Revision: D61054392