Skip to content

Commit

Permalink
Rewrite tests that depend on propTypes warnings (#28325)
Browse files Browse the repository at this point in the history
In preparation for #28207.

These tests aren't actually testing propTypes, they just use them to
verify we can display a meaningful component name. We've mostly moved
away from warnings that display component names directly in favor of
component stacks. So let's just replace these with tests asserting the
component names show up in stacks.

DiffTrain build for commit adadb81.
  • Loading branch information
gaearon committed Feb 14, 2024
1 parent 3b09625 commit 01f540a
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25922,7 +25922,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-canary-64e755d73-20240214";
var ReactVersion = "18.3.0-canary-adadb8169-20240214";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9169,7 +9169,7 @@ var devToolsConfig$jscomp$inline_1024 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-64e755d73-20240214",
version: "18.3.0-canary-adadb8169-20240214",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1205 = {
Expand Down Expand Up @@ -9200,7 +9200,7 @@ var internals$jscomp$inline_1205 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-64e755d73-20240214"
reconcilerVersion: "18.3.0-canary-adadb8169-20240214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1206 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9597,7 +9597,7 @@ var devToolsConfig$jscomp$inline_1066 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-64e755d73-20240214",
version: "18.3.0-canary-adadb8169-20240214",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1246 = {
Expand Down Expand Up @@ -9628,7 +9628,7 @@ var internals$jscomp$inline_1246 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-64e755d73-20240214"
reconcilerVersion: "18.3.0-canary-adadb8169-20240214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1247 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-canary-64e755d73-20240214";
var ReactVersion = "18.3.0-canary-adadb8169-20240214";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -590,4 +590,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-64e755d73-20240214";
exports.version = "18.3.0-canary-adadb8169-20240214";
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-64e755d73-20240214";
exports.version = "18.3.0-canary-adadb8169-20240214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
64e755d7374d753c75dc16ba1a4a09ce7b8689dd
adadb8169e781ff645c61aa558dc901b1c2c97f4

0 comments on commit 01f540a

Please sign in to comment.