Clear fields on unmount of fiber to avoid memory leak (#14276)

* Clear fields on unmount of fiber to avoid memory leak
facebook · Nov 19, 2018 · 0e9cb3f · 0e9cb3f
1 parent 5926765
commit 0e9cb3f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js
@@ -728,9 +728,14 @@ function detachFiber(current: Fiber) {
   // itself will be GC:ed when the parent updates the next time.
   current.return = null;
   current.child = null;
-  if (current.alternate) {
-    current.alternate.child = null;
-    current.alternate.return = null;
+  current.memoizedState = null;
+  current.updateQueue = null;
+  const alternate = current.alternate;
+  if (alternate !== null) {
+    alternate.return = null;
+    alternate.child = null;
+    alternate.memoizedState = null;
+    alternate.updateQueue = null;
   }
 }