Skip to content

Commit

Permalink
Remove unused returnFiber (#28504)
Browse files Browse the repository at this point in the history
There is no use of `returnFiber` here, it can be removed.

DiffTrain build for [64f354c](64f354c)
  • Loading branch information
kassens committed Mar 6, 2024
1 parent 401192f commit 8506f82
Show file tree
Hide file tree
Showing 19 changed files with 113 additions and 113 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c11b196ae3e2e3c5d143d9102b35a6b6fa97c849
64f354cf27a17c4e5b0dfcd908e47940cf947771
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-5741f0db";
exports.version = "18.3.0-www-classic-8c94b449";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-6ddd4df1";
exports.version = "18.3.0-www-classic-b219bf7d";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "18.3.0-www-classic-14143ab0";
var ReactVersion = "18.3.0-www-classic-81c495cd";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -6652,7 +6652,7 @@ if (__DEV__) {
return null;
}

function mapRemainingChildren(returnFiber, currentFirstChild) {
function mapRemainingChildren(currentFirstChild) {
// Add the remaining children to a temporary map so that we can find them by
// keys quickly. Implicit (null) keys get added to this set with their index
// instead.
Expand Down Expand Up @@ -7432,7 +7432,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; newIdx < newChildren.length; newIdx++) {
var _newFiber2 = updateFromMap(
Expand Down Expand Up @@ -7652,7 +7652,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; !step.done; newIdx++, step = newChildren.next()) {
var _newFiber4 = updateFromMap(
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "18.3.0-www-modern-0883d4be";
var ReactVersion = "18.3.0-www-modern-c4d09ac8";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -6417,7 +6417,7 @@ if (__DEV__) {
return null;
}

function mapRemainingChildren(returnFiber, currentFirstChild) {
function mapRemainingChildren(currentFirstChild) {
// Add the remaining children to a temporary map so that we can find them by
// keys quickly. Implicit (null) keys get added to this set with their index
// instead.
Expand Down Expand Up @@ -7197,7 +7197,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; newIdx < newChildren.length; newIdx++) {
var _newFiber2 = updateFromMap(
Expand Down Expand Up @@ -7417,7 +7417,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; !step.done; newIdx++, step = newChildren.next()) {
var _newFiber4 = updateFromMap(
Expand Down
18 changes: 9 additions & 9 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1913,13 +1913,13 @@ function createChildReconciler(shouldTrackSideEffects) {
(currentFirstChild = currentFirstChild.sibling);
return null;
}
function mapRemainingChildren(returnFiber, currentFirstChild) {
for (returnFiber = new Map(); null !== currentFirstChild; )
function mapRemainingChildren(currentFirstChild) {
for (var existingChildren = new Map(); null !== currentFirstChild; )
null !== currentFirstChild.key
? returnFiber.set(currentFirstChild.key, currentFirstChild)
: returnFiber.set(currentFirstChild.index, currentFirstChild),
? existingChildren.set(currentFirstChild.key, currentFirstChild)
: existingChildren.set(currentFirstChild.index, currentFirstChild),
(currentFirstChild = currentFirstChild.sibling);
return returnFiber;
return existingChildren;
}
function useFiber(fiber, pendingProps) {
fiber = createWorkInProgress(fiber, pendingProps);
Expand Down Expand Up @@ -2268,7 +2268,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return resultingFirstChild;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
newIdx < newChildren.length;
newIdx++
)
Expand Down Expand Up @@ -2353,7 +2353,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return iteratorFn;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
!step.done;
newIdx++, step = newChildrenIterable.next()
)
Expand Down Expand Up @@ -10600,7 +10600,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-cad557f7",
version: "18.3.0-www-classic-988117e8",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1320 = {
Expand Down Expand Up @@ -10631,7 +10631,7 @@ var internals$jscomp$inline_1320 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-cad557f7"
reconcilerVersion: "18.3.0-www-classic-988117e8"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1321 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
18 changes: 9 additions & 9 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1709,13 +1709,13 @@ function createChildReconciler(shouldTrackSideEffects) {
(currentFirstChild = currentFirstChild.sibling);
return null;
}
function mapRemainingChildren(returnFiber, currentFirstChild) {
for (returnFiber = new Map(); null !== currentFirstChild; )
function mapRemainingChildren(currentFirstChild) {
for (var existingChildren = new Map(); null !== currentFirstChild; )
null !== currentFirstChild.key
? returnFiber.set(currentFirstChild.key, currentFirstChild)
: returnFiber.set(currentFirstChild.index, currentFirstChild),
? existingChildren.set(currentFirstChild.key, currentFirstChild)
: existingChildren.set(currentFirstChild.index, currentFirstChild),
(currentFirstChild = currentFirstChild.sibling);
return returnFiber;
return existingChildren;
}
function useFiber(fiber, pendingProps) {
fiber = createWorkInProgress(fiber, pendingProps);
Expand Down Expand Up @@ -2064,7 +2064,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return resultingFirstChild;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
newIdx < newChildren.length;
newIdx++
)
Expand Down Expand Up @@ -2149,7 +2149,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return iteratorFn;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
!step.done;
newIdx++, step = newChildrenIterable.next()
)
Expand Down Expand Up @@ -10255,7 +10255,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-5c2d3ed7",
version: "18.3.0-www-modern-86dc6ab7",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1300 = {
Expand Down Expand Up @@ -10286,7 +10286,7 @@ var internals$jscomp$inline_1300 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-5c2d3ed7"
reconcilerVersion: "18.3.0-www-modern-86dc6ab7"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1301 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -11376,7 +11376,7 @@ if (__DEV__) {
return null;
}

function mapRemainingChildren(returnFiber, currentFirstChild) {
function mapRemainingChildren(currentFirstChild) {
// Add the remaining children to a temporary map so that we can find them by
// keys quickly. Implicit (null) keys get added to this set with their index
// instead.
Expand Down Expand Up @@ -12166,7 +12166,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; newIdx < newChildren.length; newIdx++) {
var _newFiber2 = updateFromMap(
Expand Down Expand Up @@ -12401,7 +12401,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; !step.done; newIdx++, step = newChildren.next()) {
var _newFiber4 = updateFromMap(
Expand Down Expand Up @@ -36034,7 +36034,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-classic-78291ba2";
var ReactVersion = "18.3.0-www-classic-3e5b27d2";

function createPortal$1(
children,
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -11338,7 +11338,7 @@ if (__DEV__) {
return null;
}

function mapRemainingChildren(returnFiber, currentFirstChild) {
function mapRemainingChildren(currentFirstChild) {
// Add the remaining children to a temporary map so that we can find them by
// keys quickly. Implicit (null) keys get added to this set with their index
// instead.
Expand Down Expand Up @@ -12128,7 +12128,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; newIdx < newChildren.length; newIdx++) {
var _newFiber2 = updateFromMap(
Expand Down Expand Up @@ -12363,7 +12363,7 @@ if (__DEV__) {
return resultingFirstChild;
} // Add all children to a key map for quick lookups.

var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.

for (; !step.done; newIdx++, step = newChildren.next()) {
var _newFiber4 = updateFromMap(
Expand Down Expand Up @@ -35881,7 +35881,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-modern-8a38254f";
var ReactVersion = "18.3.0-www-modern-b7723bc0";

function createPortal$1(
children,
Expand Down
20 changes: 10 additions & 10 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2646,13 +2646,13 @@ function createChildReconciler(shouldTrackSideEffects) {
(currentFirstChild = currentFirstChild.sibling);
return null;
}
function mapRemainingChildren(returnFiber, currentFirstChild) {
for (returnFiber = new Map(); null !== currentFirstChild; )
function mapRemainingChildren(currentFirstChild) {
for (var existingChildren = new Map(); null !== currentFirstChild; )
null !== currentFirstChild.key
? returnFiber.set(currentFirstChild.key, currentFirstChild)
: returnFiber.set(currentFirstChild.index, currentFirstChild),
? existingChildren.set(currentFirstChild.key, currentFirstChild)
: existingChildren.set(currentFirstChild.index, currentFirstChild),
(currentFirstChild = currentFirstChild.sibling);
return returnFiber;
return existingChildren;
}
function useFiber(fiber, pendingProps) {
fiber = createWorkInProgress(fiber, pendingProps);
Expand Down Expand Up @@ -3004,7 +3004,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return resultingFirstChild;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
newIdx < newChildren.length;
newIdx++
)
Expand Down Expand Up @@ -3095,7 +3095,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return iteratorFn;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
!step.done;
newIdx++, step = newChildrenIterable.next()
)
Expand Down Expand Up @@ -17237,7 +17237,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-513335d7",
version: "18.3.0-www-classic-caa15134",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2181 = {
Expand Down Expand Up @@ -17267,7 +17267,7 @@ var internals$jscomp$inline_2181 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-513335d7"
reconcilerVersion: "18.3.0-www-classic-caa15134"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2182 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17598,4 +17598,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
};
exports.version = "18.3.0-www-classic-513335d7";
exports.version = "18.3.0-www-classic-caa15134";
20 changes: 10 additions & 10 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -2540,13 +2540,13 @@ function createChildReconciler(shouldTrackSideEffects) {
(currentFirstChild = currentFirstChild.sibling);
return null;
}
function mapRemainingChildren(returnFiber, currentFirstChild) {
for (returnFiber = new Map(); null !== currentFirstChild; )
function mapRemainingChildren(currentFirstChild) {
for (var existingChildren = new Map(); null !== currentFirstChild; )
null !== currentFirstChild.key
? returnFiber.set(currentFirstChild.key, currentFirstChild)
: returnFiber.set(currentFirstChild.index, currentFirstChild),
? existingChildren.set(currentFirstChild.key, currentFirstChild)
: existingChildren.set(currentFirstChild.index, currentFirstChild),
(currentFirstChild = currentFirstChild.sibling);
return returnFiber;
return existingChildren;
}
function useFiber(fiber, pendingProps) {
fiber = createWorkInProgress(fiber, pendingProps);
Expand Down Expand Up @@ -2898,7 +2898,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return resultingFirstChild;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
newIdx < newChildren.length;
newIdx++
)
Expand Down Expand Up @@ -2989,7 +2989,7 @@ function createChildReconciler(shouldTrackSideEffects) {
return iteratorFn;
}
for (
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
oldFiber = mapRemainingChildren(oldFiber);
!step.done;
newIdx++, step = newChildrenIterable.next()
)
Expand Down Expand Up @@ -16753,7 +16753,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-f13b626a",
version: "18.3.0-www-modern-2a863e2d",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2145 = {
Expand Down Expand Up @@ -16784,7 +16784,7 @@ var internals$jscomp$inline_2145 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-f13b626a"
reconcilerVersion: "18.3.0-www-modern-2a863e2d"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2146 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17043,4 +17043,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
};
exports.version = "18.3.0-www-modern-f13b626a";
exports.version = "18.3.0-www-modern-2a863e2d";
Loading

0 comments on commit 8506f82

Please sign in to comment.